Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp374159imp; Wed, 20 Feb 2019 01:42:35 -0800 (PST) X-Google-Smtp-Source: AHgI3IamGhzjfZd9MzN0BPwnuI86FRf1iVcFk/YdUSMoeCcjjP+SV7WjN2dPbJmXf37QTvxaB+cv X-Received: by 2002:aa7:8392:: with SMTP id u18mr33989444pfm.59.1550655755237; Wed, 20 Feb 2019 01:42:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550655755; cv=none; d=google.com; s=arc-20160816; b=JOfntlMUquORRQJp4zV3zuKb5xYrXh2NwLiJlDaTaAq3WXD9s5mOkU5VuDrMRdOp6u WaF4D7EbSUk3k2+B2AMf4YaNwkKyo54mZosEerChadpwVGWieua4qVBrsjyNfVsRyKmz m2eOi1KekICRVRaHq52p8jghKyXiwrn+NOYS/zp1DOCqyqBnWqDN2vt8VnyR9ttQUgXi Gmm1j7oB7aR3lx4zo0dnKBcnGcR+wwgq9G+NvSkfoyfMmUA3TDFSg3WvLjoZ38A5n43k flTiNFWPOiIk89WPVMaWnsYt7nzW7kwhB2NJ1q07lOcXZpK/rclMYk05BMS3ZHNSqeNz Owfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=q7KwUMduoIgXX/1dLJHenMBhGEKnA/ohjY2HV20jK04=; b=PXlOSajriplM4IIC5IUBt89xL8z3qXVhvVS3SBgrLCaPyzq7b/y5kBaVbUxb8y5wrJ 35JAreubEzCkwMEue8Q8VFSybOS4Yd954I+WxRmYANJopQiXJqdGchVhsrwIT22wFW3s ZYcrNsyR/MWzih4syr+8vbHZ4DpUpJj7FCioE+YxCwCSTHTsFMEHqOq0px8ZbEFjUHhZ Tw4STtG97vCeoEt4I7kcjSXRk3kETlJtAjgrBEK2kZ1yZOL+4B1nfsiuYuhNRRJggD3x HT2Zh29Q4x4IoAWBxZLoynhmSGfWTEf1N+5M8RiuuUBEo4bVq0kV+M4OLhMFQo+UANVB +czg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k7a9BBvl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13si17970605pgh.196.2019.02.20.01.42.19; Wed, 20 Feb 2019 01:42:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k7a9BBvl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbfBTJlt (ORCPT + 99 others); Wed, 20 Feb 2019 04:41:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:44282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfBTJlt (ORCPT ); Wed, 20 Feb 2019 04:41:49 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80B432089F; Wed, 20 Feb 2019 09:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550655708; bh=ByzLbcUcmSF3faEyYikSKFWJ858JBmNi+gUQLh8XMn0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k7a9BBvleNSL4T7JuNjNLgoi4p3xYsIRgoawPlm08ODqsVE/abSOHGr90IU23oGnc WM/1Q7xGl464CRiHEtPHeDyu+6hwN26+oXN047Prbsb9irOf9s1eeoRXI4iAN07afY dcnfC7uUcT8vVU1u7c+Eao/yBpKKZ2RKlcrYCQg4= Date: Wed, 20 Feb 2019 09:41:40 +0000 From: Jonathan Cameron To: Lucas Oshiro Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, matt.ranostay@konsulko.com Subject: Re: [PATCH 0/5] iio:potentiostat:lmp91000: Adjust codestyle, and minor cleanup changes Message-ID: <20190220094140.0f2ad613@archlinux> In-Reply-To: <20190218172236.7781-1-lucasseikioshiro@gmail.com> References: <20190218172236.7781-1-lucasseikioshiro@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Feb 2019 14:22:31 -0300 Lucas Oshiro wrote: > Hi, > > We solved some checkpath.el CHECKs and WARNINGs. We also inverted the arms of > an if statement, in order to make the code smaller as the else statement was > supressed. We added a missing '\n' on a dev_err message. Please try to identify the original author. Matt is still definitely about, and he is obviously likely to be able to provide the most detailed review of changes to this driver. Thanks, Jonathan > > Lucas Oshiro (5): > iio:potentiostat:lmp91000: remove unnecessary parentheses > iio:potentiostat:lmp91000: insert braces around if arms > iio:potentiostat:lmp91000: reduce line width and remove blank line > iio:potentiostat:lmp91000: invert if statement > iio:potentiostat:lmp91000: add '\n' on dev_err > > drivers/iio/potentiostat/lmp91000.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) >