Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Feb 2019 09:49:21 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Joe Perches <joe@perches.com>
Cc:     Lucas Oshiro <lucasseikioshiro@gmail.com>, knaack.h@gmx.de,
        lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com,
        Anderson Reis <andersonreisrosa@gmail.com>
Subject: Re: [PATCH 5/5] iio:potentiostat:lmp91000: add '\n' on dev_err
Message-ID: <20190220094921.6777d6f8@archlinux>
In-Reply-To: <d5d88a5acc984554240047944cb3071371025085.camel@perches.com>
References: <20190218172236.7781-1-lucasseikioshiro@gmail.com>
        <20190218172236.7781-6-lucasseikioshiro@gmail.com>
        <d5d88a5acc984554240047944cb3071371025085.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 18 Feb 2019 13:01:23 -0800
Joe Perches <joe@perches.com> wrote:

> On Mon, 2019-02-18 at 14:22 -0300, Lucas Oshiro wrote:
> > Add missing '\n' at the end of dev_err message on line 215. =20
> []
> > diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentio=
stat/lmp91000.c =20
> []
> > @@ -212,7 +212,7 @@ static int lmp91000_read_config(struct lmp91000_dat=
a *data)
> >  	ret =3D of_property_read_u32(np, "ti,tia-gain-ohm", &val);
> >  	if (ret) {
> >  		if (!of_property_read_bool(np, "ti,external-tia-resistor")) {
> > -			dev_err(dev, "no ti,tia-gain-ohm defined");
> > +			dev_err(dev, "no ti,tia-gain-ohm defined\n"); =20
>=20
> Perhaps a copy/paste error as the test is for
> external-tia-resistor and not tia-gain-ohm
>=20
It is an odd construct, but I think this is correct.  What it is actually
saying is that, given that we don't have an external resistor, we care
that the tia-gain-ohm isn't set (otherwise it wouldn't matter).

=46rom the docs
  - ti,external-tia-resistor: if the property ti,tia-gain-ohm is not define=
d this
    needs to be set to signal that an external resistor value is being used.

So, it might be ideal to say that tia-gain-ohm is not defined and we do
not have an external resistor specified.

So not wrong, but could be more informative!  So perhaps a follow up patch
to tidy that up would be good.

Jonathan
>=20