Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp382416imp; Wed, 20 Feb 2019 01:54:28 -0800 (PST) X-Google-Smtp-Source: AHgI3IbO6h+z79lx90MSzdjMJfL3FbjBQopDe5HjTNJe7FlALm9LyTz4Ru4/m7MoKqa0nD9pBhnD X-Received: by 2002:a62:4ec5:: with SMTP id c188mr9055526pfb.230.1550656468125; Wed, 20 Feb 2019 01:54:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550656468; cv=none; d=google.com; s=arc-20160816; b=PtoSWjv0ewIRFa+tyyPD5ToX8YISHbW8wadqXg0If4mc4uIcWx4ix5YGGY9l6UwB6q mft9ypSU62Kz+88G7sHRFa2e/T26uqPW5fRHM6Phk2/KMfn8qaj82aK9l+Mg+odMCUEG VRekhirIUxyEf5WyksB1RrsHSrnCHRFmrZjdCEYJdA3coMqEdssk0VYqAIs8zBh0jrTW EwigK8OJJ+IAEuYyXTHzLqABPL0IeNba39ON+azdPnBYZbChW4RzUou4sJSOdAAtgjMW V0cCQ/9ZHX193aJH15GjJREgBQWSB4LsEv2zhvND21kDKaEwUckMv+TYpuLl+gtsr/rR wBSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=6PzXl7HZONN4035fIPsM0lhsW6FZpjgMkeqMgrv9A4Q=; b=hfFVHnZ3tfTaLWAbfsmhAsphSQWLrrerCpwka7xvfsRuqC8xKLS1LC99B2RW4psVUl 64gwnWfp5uWwB4nG9DN0VBAOB1pnZtXWKp8SWXk4EO/4MYBBdjK5Qbs2kqhfKagR5WLy bAoV52+VKmx6Jt/Pb1yClpaE5ST9L1t/a8W2E0pulFdXvYpaiPm1lsjlomgFQXxGjmPR jqMh/ps5jNEuXA98kU9cuTggKPfc/yDEQaoFSQJjtPEHsY1o3B47uuWChhjg5QIB3bZb ESkKSrgdyPRuLFd2JGaEGw1GQ7/qzeaVUhNZjrn2Bwkki/dNua+XYwjwiEdrXKncvPyF SCqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="pgu3C/TT"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24si11286196pgw.46.2019.02.20.01.54.12; Wed, 20 Feb 2019 01:54:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="pgu3C/TT"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbfBTJxR (ORCPT + 99 others); Wed, 20 Feb 2019 04:53:17 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46527 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbfBTJxR (ORCPT ); Wed, 20 Feb 2019 04:53:17 -0500 Received: by mail-lf1-f65.google.com with SMTP id g12so7476553lfb.13 for ; Wed, 20 Feb 2019 01:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6PzXl7HZONN4035fIPsM0lhsW6FZpjgMkeqMgrv9A4Q=; b=pgu3C/TTol1ilNPIOY1rtKDRXCawseSsW4U0HR/3Y2+y0jHI5gsebC92v1YuQJEcYw Hjm/ocy8py1zmSSPz5JqyAUZERF7BZjf7SjMrR+hqmepVHlP88B7T+L7b4gqoCbZ0otS UAcDfXdF2WgVTgETEIzf7vZ6NuTkJZBP6f7iuoEip1+0QDwwEl4ULqm1KDKhw2AUYha2 ADbT84ujhlY9cUBCrZZs6/oaS1u2BPh62I7WLVN43NJ95VYeqd2d5kTAwgFD2brhgoRk jB0d43krntU3+gR7Z5ft/a5F/DH8b9tl7T3MYzqCWTgtSeyFviOTgkz/P6njaEe693vT elSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6PzXl7HZONN4035fIPsM0lhsW6FZpjgMkeqMgrv9A4Q=; b=HdCD/9pmTeiN/8vNKdQSikTpbjspk3NnDucuOqPsRaEYLCdUcgHGSOOeBLEjvkYBWF z/iZq1c/g5yGt8hltcpaA1T/0A5v/0Ywark1iXCMEsX6EDink7VFhKFjuUs/xWszhy0n eWVjLA3QkscAsaPp28my2foc2bb1GoVElYtooL61Hb2tUsx09TY0jLsia5DZjJsgXdV8 TNz3x08n0Lz1Xd9/QivN/csctU9a956Y0i+xjDw/YjmPRpAnfBjRaK2vXVR6J1zX3l04 qvhYo3EDA0ccDgg9BNqy/sqPOIxqC6gFEY36kqbLnmbIkckDJDZbGI6UrOrNI9vQOQ0Z HnqA== X-Gm-Message-State: AHQUAubPmISgC1qC0TJOMwMMnpTZz3ECsoVGZwMtflBoyb90X2mWA6+6 +/1m9UpXOkLPWMtZWZWiNX26ZAJ7CtsNfnDaW7KlGg== X-Received: by 2002:a19:7b0e:: with SMTP id w14mr19583160lfc.8.1550656395265; Wed, 20 Feb 2019 01:53:15 -0800 (PST) MIME-Version: 1.0 References: <1550217696-3006-1-git-send-email-wdjjwb@163.com> In-Reply-To: <1550217696-3006-1-git-send-email-wdjjwb@163.com> From: Linus Walleij Date: Wed, 20 Feb 2019 10:53:03 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: nomadik: fix possible object reference leak To: WangBo Cc: "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Linux ARM , wang.bo116@zte.com.cn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2019 at 9:01 AM WangBo wrote: > The of_find_device_by_node takes a reference to the struct device > when find the match device ,we should release it when fail. > > Signed-off-by: WangBo Patch applied! Yours, Linus Walleij