Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Feb 2019 10:30:20 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Stefan Popa <stefan.popa@analog.com>
Cc:     <robh+dt@kernel.org>, <Michael.Hennerich@analog.com>,
        <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
        <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
        <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 3/6] iio: imu: adis16480: Add OF device ID table
Message-ID: <20190220103020.095382d6@archlinux>
In-Reply-To: <1550596338-24220-4-git-send-email-stefan.popa@analog.com>
References: <1550596338-24220-1-git-send-email-stefan.popa@analog.com>
        <1550596338-24220-4-git-send-email-stefan.popa@analog.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 19 Feb 2019 19:12:15 +0200
Stefan Popa <stefan.popa@analog.com> wrote:

> The driver does not have a struct of_device_id table, but supported
> devices are registered via Device Trees. This patch adds OF device ID
> table.
> 
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
This is fine, I'll pick it up in v2.
> ---
>  drivers/iio/imu/adis16480.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index 38ba0c1..7ae71f4 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -988,9 +988,19 @@ static const struct spi_device_id adis16480_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(spi, adis16480_ids);
>  
> +static const struct of_device_id adis16480_of_match[] = {
> +	{ .compatible = "adi,adis16375" },
> +	{ .compatible = "adi,adis16480" },
> +	{ .compatible = "adi,adis16485" },
> +	{ .compatible = "adi,adis16488" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, adis16480_of_match);
> +
>  static struct spi_driver adis16480_driver = {
>  	.driver = {
>  		.name = "adis16480",
> +		.of_match_table = adis16480_of_match,
>  	},
>  	.id_table = adis16480_ids,
>  	.probe = adis16480_probe,