Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp441956imp; Wed, 20 Feb 2019 03:02:06 -0800 (PST) X-Google-Smtp-Source: AHgI3IbrOOP1VXHV73QqrZzNbdzJ6t/EeJLh8UOQE0rM8KOXXbuBVB8e4RETW7KhVukkydSmGXKJ X-Received: by 2002:a17:902:6949:: with SMTP id k9mr36162478plt.85.1550660526826; Wed, 20 Feb 2019 03:02:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550660526; cv=none; d=google.com; s=arc-20160816; b=H+WhsSKxLFbdJqjHH4b899Quhwppu0PkgTksBnqwhCy09RQBeiqraEzmS2D/oiStmF K7wepyHr2vSM+71J1aAqTwTpsWmQiAL63DMb7+8Ksj+M89rRf9Xw/f6+f812LsqKHjvR nU0Cah2T1aj1Dgkx+DqWwmeceEfFxCN4EXlcv3rfAnsAnUw0ncxtSOO1SpOvwJZoCDn8 KlqUgN34aAQjEZVa7cAbnkPu6o+xj0yqnx7dndnaglvj5ABcFc8VbdrkSQRZ7gNxOYHD eZPwWxH4Djy0rSn+C6y+DOWJP7cWKpoZb201rv+5snkkcgxZqf0UlEzcOM8T3XAGehIV lJ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=L7A5iv4B90/vPUC40FQ2WUwosPUTlA3gM7A6L7hk134=; b=tvcuEcTJJucFfnQ6yjh2mqUFTCb9zg7ntZVD7BH86zPk7sZFFEOMHVFYDdjCVbV3C3 lAUxDaStkCnXCWMeArRGz/roEfTpOm5tGGMdt8QPZxJBUEF7YzkNIA8EqiQ7609iwRMl DtoGpbX+N8C1QF/s5Zk8IvzpGyMf45z8bEoFjJp8QfK38MrGA82opi61486Cr/kuHS7i fkNsx7gnzko8sEjoB/hKzAiGdrwG4MuqStDEWfNZClec0Yj1JKzNuy13E3ZLUVhmeIV1 mvshPb8UmsGc/g83m28XIVMSwJQ/2EOUW4UHH3wLnS+jffOaHKvQvNa0UX2LMOq9xUe3 vVeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l2si18311193pfc.287.2019.02.20.03.01.51; Wed, 20 Feb 2019 03:02:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727803AbfBTK7m (ORCPT + 99 others); Wed, 20 Feb 2019 05:59:42 -0500 Received: from mx-rz-3.rrze.uni-erlangen.de ([131.188.11.22]:42164 "EHLO mx-rz-3.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfBTK7m (ORCPT ); Wed, 20 Feb 2019 05:59:42 -0500 Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-3.rrze.uni-erlangen.de (Postfix) with ESMTPS id 444F3v20Zpz1yR3; Wed, 20 Feb 2019 11:59:39 +0100 (CET) Authentication-Results: mx-rz-3.rrze.uni-erlangen.de; dkim=none reason="no signature"; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Virus-Scanned: amavisd-new at boeck5.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 10.21.3.88 Received: from fau.de (faustud-010-021-003-088.pool.uni-erlangen.de [10.21.3.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX1/8CY91/8H/yA5l8VtHDkBsyYQxTy09J+I=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 444F3s079zz1yFZ; Wed, 20 Feb 2019 11:59:37 +0100 (CET) From: Jonas Rabenstein To: linux-perf-users@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Steven Rostedt (VMware)" , Andi Kleen , "Tzvetomir Stoyanov (VMware)" , linux-kernel@vger.kernel.org, Milian Wolff , Jonas Rabenstein Subject: [PATCHv2 2/2] perf evsel: add inline functions to sample callchain output Date: Wed, 20 Feb 2019 11:59:13 +0100 Message-Id: <20190220105913.1321-1-jonas.rabenstein@studium.uni-erlangen.de> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190220001116.3b3yyndjjmqs3hmm@studium.uni-erlangen.de> References: <20190220001116.3b3yyndjjmqs3hmm@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Whenever a callchain shall be printed search for each address whether inline information is available and add those symbols to the output if symbol_conf.inline_name is enabled. Signed-off-by: Jonas Rabenstein --- v2: - fix handling of static binaries tools/perf/util/evsel_fprintf.c | 55 +++++++++++++++++++++++++++++---- 1 file changed, 49 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index c710f687ddf4..a8d6465af1aa 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -168,6 +168,52 @@ static int __fprintf_callchain_link(u64 ip, struct map *map, struct symbol *symb return printed; } +static int __fprintf_callchain(struct callchain_cursor_node *node, bool first, + int left_alignment, unsigned int print_opts, + FILE *fp) +{ + int printed = 0; + struct inline_node *inline_node; + struct inline_list *ilist; + u64 addr; + + if (!symbol_conf.inline_name) + goto no_inline; + + if (!node->map || !node->map->dso) + goto no_inline; + + addr = node->map->map_ip(node->map, node->ip); + addr = map__rip_2objdump(node->map, addr); + + inline_node = inlines__tree_find(&node->map->dso->inlined_nodes, + addr); + if (!inline_node) { + inline_node = dso__parse_addr_inlines(node->map->dso, + addr, node->sym); + if (!inline_node) + goto no_inline; + inlines__tree_insert(&node->map->dso->inlined_nodes, + inline_node); + } + + list_for_each_entry(ilist, &inline_node->val, list) { + printed += __fprintf_callchain_link(node->ip, node->map, + ilist->symbol, + ilist->srcline, + first, left_alignment, + print_opts, fp); + first = (first && printed == 0); + } + + return printed; + +no_inline: + return __fprintf_callchain_link(node->ip, node->map, node->sym, + NULL, first, left_alignment, + print_opts, fp); +} + int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, unsigned int print_opts, struct callchain_cursor *cursor, FILE *fp) @@ -183,12 +229,9 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, if (!node) break; - - printed += __fprintf_callchain_link(node->ip, node->map, - node->sym, NULL, - (printed == 0), - left_alignment, - print_opts, fp); + printed += __fprintf_callchain(node, (printed == 0), + left_alignment, + print_opts, fp); /* Add srccode here too? */ if (symbol_conf.bt_stop_list && -- 2.19.2