Date: Sun, 14 Mar 2004 20:14:57 -0800
From: Andrew Morton <akpm@osdl.org>
To: Herbert Poetzl <herbert@13thfloor.at>
Cc: torvalds@osdl.org, viro@parcelfarce.linux.theplanet.co.uk,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4)
Message-Id: <20040314201457.23fdb96e.akpm@osdl.org>
In-Reply-To: <20040315035506.GB30948@MAIL.13thfloor.at>
References: <20040315035506.GB30948@MAIL.13thfloor.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 947
Lines: 20

Herbert Poetzl <herbert@13thfloor.at> wrote:
>
>  ; this patch adds some functionality to the --bind
>  ; type of vfs mounts.

This won't apply any more.  We very recently changed a large number of
filesystems to not call update_atime() from within their readdir functions.
That operation was hoisted up to vfs_readdir().

Also, rather than adding MNT_IS_RDONLY() and having to remember to check
both the inode and the mount all over the kernel it would be better to
change IS_RDONLY() to take two arguments - the inode and the vfsmnt.  That
way we won't miss places, and unconverted code simpy won't compile, thus
drawing attention to itself.  I don't know if this is feasible, but please
consider it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/