Date: Sun, 14 Mar 2004 20:34:27 -0800
From: Andrew Morton <akpm@osdl.org>
To: Herbert Poetzl <herbert@13thfloor.at>
Cc: torvalds@osdl.org, viro@parcelfarce.linux.theplanet.co.uk,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4)
Message-Id: <20040314203427.27857fd9.akpm@osdl.org>
In-Reply-To: <20040315042541.GA31412@MAIL.13thfloor.at>
References: <20040315035506.GB30948@MAIL.13thfloor.at>
	<20040314201457.23fdb96e.akpm@osdl.org>
	<20040315042541.GA31412@MAIL.13thfloor.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1548
Lines: 38

Herbert Poetzl <herbert@13thfloor.at> wrote:
>
> On Sun, Mar 14, 2004 at 08:14:57PM -0800, Andrew Morton wrote:
> > Herbert Poetzl <herbert@13thfloor.at> wrote:
> > >
> > >  ; this patch adds some functionality to the --bind
> > >  ; type of vfs mounts.
> > 
> > This won't apply any more.  We very recently changed a large number of
> > filesystems to not call update_atime() from within their readdir functions.
> > That operation was hoisted up to vfs_readdir().
> 
> good decision, very recently probably means in the bk repository,
> is there any link where I could download those changes?

The latest diff against the most-recently-release kernel is always at

	http://www.kernel.org/pub/linux/kernel/v2.5/testing/cset/

the topmost link.

> > Also, rather than adding MNT_IS_RDONLY() and having to remember to check
> > both the inode and the mount all over the kernel it would be better to
> > change IS_RDONLY() to take two arguments - the inode and the vfsmnt.  That
> > way we won't miss places, and unconverted code simpy won't compile, thus
> > drawing attention to itself.  I don't know if this is feasible, but please
> > consider it.
> 
> I don't have a problem with that, and it sounds good to me so
> far, so I'll have a look at it, and will update the patch
> accordingly ...

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/