Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp579700imp; Wed, 20 Feb 2019 05:31:35 -0800 (PST) X-Google-Smtp-Source: AHgI3IYABct1tra2ItoprC8EhqmfBYtD4iZZ6VHdi8zUbZCs57n3sqEWOkBfaOn93AT0R5CflXSt X-Received: by 2002:a63:2312:: with SMTP id j18mr29360900pgj.344.1550669495771; Wed, 20 Feb 2019 05:31:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550669495; cv=none; d=google.com; s=arc-20160816; b=FTwCpCk/CYukXDheXEuikd6GYg/Fz6EMjo7enPFrTuz4cWSeqK+koHKUWX+OqJSP7m YP7gLlssJ+NQLsm57R6vBUTa4kFoLpHp5VosQ/XqrND4KBEV0L0lnPb+MK8/qXNv4Cv/ Bn5ZmxMkh/LEDt+M5aTlJdY5Ff4GAjH68lKIt5Xhn6VkJLERistwxnbeT+Z/FlVrR0SM 97tMxbWPo9OzP5qR7L0ra35vio59Sfkw/CnX0NrRN/k4jkSDOM1LPXoZKNIYX4ge5Ty0 TRgsJI8HpKmPMwNft+Zwu8l0wDy9i93nxkmT9IvZKtON4h6wfTUcwY+0favRhr2M6jb5 odrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=gawY0XSlScs+iCWY+CtROU3xoX+OWMA9mfSbG0cIN94=; b=NWOp8qc9n6RE5rHxDzYGpkWZDlOJAcoo34WcVsckBAe4uQNa+n6THf5hKiOKDOZ9Oq sRCOw9lNVs9y6eEGiQ8AJ07tk6TvpNuTOQEhn9j6i+PgwbJ1k1kFM8td6OO4/iZ0tu97 7uGQASEOsTJDdvMIBPGjydTY59l0PDXwbMEwli2Yh2m3boGKT4ODl4lgqtMhPN03dNEQ kjkaFVY43Xevbwf/nQOzb8G9ITf18LDpGE1tVA+SH+5KKnPXv3r+1aU27jb2ZFhGiObz C9F699ZMjdi7GgQ8tjT0H0elpC1NUrqg+JVgvjfStZSf2JMfu1KYNuy0UPdir/x91fDd fhGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k7si18149947pgj.177.2019.02.20.05.31.20; Wed, 20 Feb 2019 05:31:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727866AbfBTNal (ORCPT + 99 others); Wed, 20 Feb 2019 08:30:41 -0500 Received: from mga06.intel.com ([134.134.136.31]:36540 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725826AbfBTNak (ORCPT ); Wed, 20 Feb 2019 08:30:40 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 05:30:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="148370369" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 20 Feb 2019 05:30:37 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 20 Feb 2019 15:30:36 +0200 Date: Wed, 20 Feb 2019 15:30:36 +0200 From: Heikki Krogerus To: Nikolaus Voss Cc: Greg Kroah-Hartman , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, nikolaus.voss@loewensteinmedical.de Subject: Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters Message-ID: <20190220133036.GB5054@kuha.fi.intel.com> References: <20180425142209.30745-1-heikki.krogerus@linux.intel.com> <20190220110017.BFA344CE86@mail.steuer-voss.de> <20190220125731.02E274CFE0@mail.steuer-voss.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220125731.02E274CFE0@mail.steuer-voss.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > adapters, but the problem described with regmap-i2c not handling > SMBus block transfers (i.e. read and writes) correctly also exists > with writes. > > As workaround, this patch adds a block write function the same way > 1a2f474d328f adds a block read function. > > Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters") > Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers") > Signed-off-by: Nikolaus Voss You are missing a "from" line with address that matches your SoB address. thanks, -- heikki