Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] powerpc: Move page table dump files in a dedicated
 subdirectory
To:     Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
References: <913780421c7b73d731bbbe04c215e29667f7c938.1550492751.git.christophe.leroy@c-s.fr>
 <87d0nm7f8l.fsf@concordia.ellerman.id.au>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <0f371616-0ab6-fe96-852a-323159c58572@c-s.fr>
Date:   Wed, 20 Feb 2019 15:00:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <87d0nm7f8l.fsf@concordia.ellerman.id.au>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Le 20/02/2019 à 14:37, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
> 
>> This patch moves the files related to page table dump in a
>> dedicated subdirectory.
>>
>> The purpose is to clean a bit arch/powerpc/mm by regrouping
>> multiple files handling a dedicated function.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>>   arch/powerpc/Kconfig.debug                                   |  4 ----
>>   arch/powerpc/mm/Makefile                                     | 10 +---------
>>   arch/powerpc/mm/ptdump/Makefile                              |  9 +++++++++
>>   arch/powerpc/mm/{ => ptdump}/dump_bats.c                     |  0
>>   arch/powerpc/mm/{ => ptdump}/dump_hashpagetable.c            |  0
>>   arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-8xx.c      |  0
>>   arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-book3s64.c |  0
>>   arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-generic.c  |  0
>>   arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.c          |  0
>>   arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.h          |  0
>>   arch/powerpc/mm/{ => ptdump}/dump_sr.c                       |  0
>>   11 files changed, 10 insertions(+), 13 deletions(-)
>>   create mode 100644 arch/powerpc/mm/ptdump/Makefile
>>   rename arch/powerpc/mm/{ => ptdump}/dump_bats.c (100%)
>>   rename arch/powerpc/mm/{ => ptdump}/dump_hashpagetable.c (100%)
>>   rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-8xx.c (100%)
>>   rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-book3s64.c (100%)
>>   rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-generic.c (100%)
>>   rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.c (100%)
>>   rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.h (100%)
>>   rename arch/powerpc/mm/{ => ptdump}/dump_sr.c (100%)
> 
> I'd like to shorten the file names as well, now that they're namespaced
> in the ptdump directory, how about:
> 
>   arch/powerpc/Kconfig.debug                                             |  4 ----
>   arch/powerpc/mm/Makefile                                               | 10 +---------
>   arch/powerpc/mm/{dump_linuxpagetables-8xx.c => ptdump/8xx.c}           |  2 +-
>   arch/powerpc/mm/ptdump/Makefile                                        |  9 +++++++++
>   arch/powerpc/mm/{dump_bats.c => ptdump/bats.c}                         |  0
>   arch/powerpc/mm/{dump_linuxpagetables-book3s64.c => ptdump/book3s64.c} |  2 +-
>   arch/powerpc/mm/{dump_hashpagetable.c => ptdump/hashpagetable.c}       |  0
>   arch/powerpc/mm/{dump_linuxpagetables.c => ptdump/ptdump.c}            |  2 +-
>   arch/powerpc/mm/{dump_linuxpagetables.h => ptdump/ptdump.h}            |  0
>   arch/powerpc/mm/{dump_sr.c => ptdump/segment_regs.c}                   |  0
>   arch/powerpc/mm/{dump_linuxpagetables-generic.c => ptdump/shared.c}    |  2 +-

Yes good idea. Do you want a v2 or will you do it ?

Christophe

> 
> 
> cheers
>