Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp617911imp; Wed, 20 Feb 2019 06:11:56 -0800 (PST) X-Google-Smtp-Source: AHgI3IYhusRm2DNF8s907FTzStg8g86iNUNil06NpTRZy4EvYi/5ADdQwtirmfIw97AToqzVXbDM X-Received: by 2002:a17:902:1122:: with SMTP id d31mr37012915pla.246.1550671916087; Wed, 20 Feb 2019 06:11:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550671916; cv=none; d=google.com; s=arc-20160816; b=Bv+EGkfROsuxVrTQJk7SvL2nbicg9SYq8Kua5ylsqClnO7muFizVcxXBCkWBfHn0jC FDueWwkIS8oJz7q/j11IQPt/pS2ygJDiUnMDAELmpOO21g2603VROUEvq4vJ8qBRWRVP XLekZjGWbCcfym+4EGY53yU7ofAJjrnwXg/lN/MvOQGweeoRHUZ+MeFMXGdAao1ah9wF IkPgkP0Iq5I9o3BiZ20LqHd6oiZN5W/9XB+v6e3E8WG910ObBV/+/I3CD3ih3SK0ANoG 00iSJDCQTjgmGImj9QPAVI0NFoL8tCEhmTHUoCX4bQeQWn+brT4FWJ0T4j2NTERXC5A6 OOXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=v7AmU/3vuEX3wvG7N6CcT+tLcsnYGS2SXNqUdSzkbJw=; b=AqqhWK5CVbx7PrWdJP92Dfl6X7gPlfbhsLu9vNdwvsLEymqAQBXsiasN5+LJzQnCk2 ipnMcyVmGiRHbQH3CR9R8uiWGnGv49LQXOeIlRZgSykayhB+T7nMqCR6R1RpH9+mxhw7 HHnrvjL2eLdhHkkjHq1iwVAZzPPdjXM6qFwSCPAMFRzIMFatvxswyhNM09qbS+5JLf9/ e3CifGfN+tpPySTrmm1w5pta9LBIWsHhKpbuu5fO7LBlS3wZS7aMlXalt0dM8YcgNoT0 ZjRWI81FR1xRUgfixVEnHZj8FtaQwAZiV6W5PZSXi1XjtMjcMjuZtbqHRKKdYapa11Bt Qe6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y40si20467091pla.251.2019.02.20.06.11.39; Wed, 20 Feb 2019 06:11:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbfBTOJ5 (ORCPT + 99 others); Wed, 20 Feb 2019 09:09:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51463 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726361AbfBTOJ5 (ORCPT ); Wed, 20 Feb 2019 09:09:57 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76A3C81250; Wed, 20 Feb 2019 14:09:57 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-129.rdu2.redhat.com [10.10.121.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1A1317B15; Wed, 20 Feb 2019 14:09:55 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <6bf441ffc1a54d06ad27ed01c6d06a58@AcuMS.aculab.com> References: <6bf441ffc1a54d06ad27ed01c6d06a58@AcuMS.aculab.com> <155066953188.21038.12015964986007814182.stgit@warthog.procyon.org.uk> To: David Laight Cc: dhowells@redhat.com, "jmorris@namei.org" , Aaro Koskinen , "stable@vger.kernel.org" , Eric Biggers , "keyrings@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] KEYS: user: Align the payload buffer MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <16011.1550671795.1@warthog.procyon.org.uk> Date: Wed, 20 Feb 2019 14:09:55 +0000 Message-ID: <16012.1550671795@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 20 Feb 2019 14:09:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Laight wrote: > I'd make the 'datalen' field 'unsigned int' at the same time. > It will use some of the hole you've made and generate better > code on most arches. Most arches? I though most, if not all, arches had a load-word instruction. Do you want to send me a patch for that? I'd rather not alter this patch at this point. I can pass the additional patch to James for the next merge window. David