Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp618153imp; Wed, 20 Feb 2019 06:12:09 -0800 (PST) X-Google-Smtp-Source: AHgI3IZyo+S6HaPcTSH8fFkMOwW7q3+HHcGm/hnveA5OJU5l28+6RLfhzECwlc6M7RmZKCi7/HZd X-Received: by 2002:a62:59d0:: with SMTP id k77mr34939394pfj.211.1550671929089; Wed, 20 Feb 2019 06:12:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550671929; cv=none; d=google.com; s=arc-20160816; b=S8IGzZu/1Nt84ShxzExaRNb56H7HkBLb0g7GsLCczHMIWO+1GlDo0ZUJ71MFZnturZ iY3FfDKF+A9XlbkJ8THl5N6jvn+Hf1KL2ikj+K7omkDY465+nwK1XxK4J2iYQgyJxwfa OtBQMZjzD05kX6xCyXxMf2jrLZpc0QH65IHRd//+VL/9B4SKekdUBC9XDwzsGXBHVf35 N08KP+T8cDXp6iiHS7eDsxIa1R8dUm4QEif8aHOtodF0TRGGCYkRnXcqZcNmKKU990AD 3iPj9pHzm68C2aWCIXjQ6JdhfsygDq2pMG2tw8p5sgVd24UAKAAv7yKEWY+N60tAupJX m1kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=CiGghaBUIBt+eWRIFaZstE7zzkTaR0bhR77TOKp0CKM=; b=T+KPfqa1KfxCpOz8/fmBECBDG0UqB98rodjTz9SF6y8kaGTQ2afm/sedgHAmUu8CFO YrhJQaV/NWLDNwtQQ2ILQetaWbKPF/WaZcfe4gYxGlu2CVF5NT/gWbkBOPfX3gID+c6k GiP+2M9msRadJ+XAWfB1A54qbuYE8VOUFKKvdFafO3oiYp4PyKDfmn/vigmmzt63TMA9 QMF4LVR0gz4yHmBGQUs6durNWSrwrdcML+HDksBKk4F8hL8Mwg2zq71e2nvppOuy7Kn4 Af18jLB/sHuw6+dcikPje2Wk/g0dFG3y7koowCs6Rm8mzRIBVbXxxPKzD3bkRHeDqL8b 3j3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18si18009807pgm.28.2019.02.20.06.11.54; Wed, 20 Feb 2019 06:12:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbfBTOKu (ORCPT + 99 others); Wed, 20 Feb 2019 09:10:50 -0500 Received: from foss.arm.com ([217.140.101.70]:58368 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbfBTOKu (ORCPT ); Wed, 20 Feb 2019 09:10:50 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35BEAEBD; Wed, 20 Feb 2019 06:10:50 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5E0F83F690; Wed, 20 Feb 2019 06:10:47 -0800 (PST) Subject: Re: [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole To: William Kucharski Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Arnd Bergmann , Ard Biesheuvel , Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , linux-kernel , Linux-MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , linux-arm-kernel@lists.infradead.org References: <20190215170235.23360-1-steven.price@arm.com> <20190215170235.23360-7-steven.price@arm.com> <52690905-1755-46BD-940B-1EE4CEA5F795@oracle.com> From: Steven Price Message-ID: <76ce9f9b-eb0d-6ad5-9f57-ff3a8fa6b074@arm.com> Date: Wed, 20 Feb 2019 14:10:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <52690905-1755-46BD-940B-1EE4CEA5F795@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/02/2019 11:35, William Kucharski wrote: > > >> On Feb 15, 2019, at 10:02 AM, Steven Price wrote: >> >> The pte_hole() callback is called at multiple levels of the page tables. >> Code dumping the kernel page tables needs to know what at what depth >> the missing entry is. Add this is an extra parameter to pte_hole(). >> When the depth isn't know (e.g. processing a vma) then -1 is passed. >> >> Note that depth starts at 0 for a PGD so that PUD/PMD/PTE retain their >> natural numbers as levels 2/3/4. > > Nit: Could you add a comment noting this for anyone wondering how to > calculate the level numbers in the future? Good point! I'll expand the comment in the header file. Thanks, Steve