Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp624485imp; Wed, 20 Feb 2019 06:18:26 -0800 (PST) X-Google-Smtp-Source: AHgI3IbsGzxeSuisQ81cm3VNVyP8vTxvkPoXeFTeyqPINrfhejXOqkKEd2FVakuB3G3UJFE1SNbJ X-Received: by 2002:a17:902:7787:: with SMTP id o7mr17929357pll.334.1550672306703; Wed, 20 Feb 2019 06:18:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550672306; cv=none; d=google.com; s=arc-20160816; b=cIF5zMBwu4WgNL1cFx5lZVFG0QvFxZ7yEQFtMcx5e0RGLD/7v5DzD56QciA7gtCWTr Eu2xaZNWNBLwjcaMEhOiTCmCOWCRglH0IuE+cO8TISOMIKqmRJ1kcSVglMh+oBGE3d6J 1NfnjoYY/209T1m5o3YRgxaIwRYBEKyggZCxW5muEZfplVqZqxqiEXzatZNWtr84otg3 XHBQ+G8ynQxmJ5qZtDxfiBmE3GaDXgGfMIkLRwJe30soX3F0u8wbHbeMESqLM+gTGOW0 jxVDAP3C+yEhG0NUj8UG6GK/Tp/1ppVwnEjssK+vunoZBs9fERwmZ4+y85pVFI6vOf7+ BWTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=QOa1CnSpxM+nUd9a3GqE4VQWwFwAfYyKohwZLzgDBbc=; b=wfKuS6b5G6UUuGfmXYRp+XsrB9OVPD7lGxmknLwXW3CyDNlRWOg482TyVDB0VWceUA iTtA2uEjSAcmwJXimlukLl1cXnS32hMRWupMoXNR1AYhumfLrJXuYvkdDaF1HMv2v2Rw MWraNvXAZo9Vq/mbPGNxLXBnq45RIyb7q7Cl9r/7mrsQ3sILyf+yemt8fg3edtxKfdIC iPPIQ9A4zXQwG1swKsMPG3UjvBa9cavDloj6tHssG3pxjSVwUiWhKr9o2RPlMIhk3XhI SqK/9Ccs47x+LJTARpwSR9NcRVQ/4UgtB+JoPqljQ+25Ms1lPca8oOiyYqtMatNCEZB2 JgWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si1943522plt.394.2019.02.20.06.18.10; Wed, 20 Feb 2019 06:18:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfBTORo (ORCPT + 99 others); Wed, 20 Feb 2019 09:17:44 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:44417 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfBTORo (ORCPT ); Wed, 20 Feb 2019 09:17:44 -0500 Received: from localhost (unknown [185.94.189.187]) (Authenticated sender: maxime.ripard@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 38AC310000D; Wed, 20 Feb 2019 14:17:37 +0000 (UTC) From: Maxime Ripard To: hans.verkuil@cisco.com, acourbot@chromium.org, sakari.ailus@linux.intel.com, Laurent Pinchart Cc: tfiga@chromium.org, posciak@chromium.org, Paul Kocialkowski , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, nicolas.dufresne@collabora.com, jenskuske@gmail.com, jernej.skrabec@gmail.com, jonas@kwiboo.se, ezequiel@collabora.com, linux-sunxi@googlegroups.com, Thomas Petazzoni , Maxime Ripard Subject: [PATCH v4 0/2] media: cedrus: Add H264 decoding support Date: Wed, 20 Feb 2019 15:17:32 +0100 Message-Id: X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Here is a new version of the H264 decoding support in the cedrus driver. As you might already know, the cedrus driver relies on the Request API, and is a reverse engineered driver for the video decoding engine found on the Allwinner SoCs. This work has been possible thanks to the work done by the people behind libvdpau-sunxi found here: https://github.com/linux-sunxi/libvdpau-sunxi/ I've tested the various ABI using this gdb script: http://code.bulix.org/jl4se4-505620?raw And this test script: http://code.bulix.org/8zle4s-505623?raw The application compiled is quite trivial: http://code.bulix.org/e34zp8-505624?raw The output is: arm: builds/arm-test-v4l2-h264-structures SHA1: fd15b30328765c2caac877e8ea8452c829b2b1d8 x86: builds/x86-test-v4l2-h264-structures SHA1: fd15b30328765c2caac877e8ea8452c829b2b1d8 x64: builds/x64-test-v4l2-h264-structures SHA1: fd15b30328765c2caac877e8ea8452c829b2b1d8 arm64: builds/arm64-test-v4l2-h264-structures SHA1: fd15b30328765c2caac877e8ea8452c829b2b1d8 Let me know if there's any flaw using that test setup, or if you have any comments on the patches. Maxime Changes from v3: - Reintroduced long term reference flag and documented it - Reintroduced ref_pic_list_p0/b0/b1 and documented it - Documented the DPB flags - Treat the scaling matrix as optional in the driver, as documented - Free the neighbor buffer - Increase the control IDs by a large margin to be safe of collisions - Reorder the fields documentation according to the structure layout - Change the tag documentation by the timestamp - Convert the sram array to size_t - Simplify the buffer retrieval from timestamp - Rebase Changes from v2: - Simplified _cedrus_write_ref_list as suggested by Jernej - Set whether the frame is used as reference using nal_ref_idc - Respect chroma_format_idc - Fixes for the scaling list and prediction tables - Wrote the documentation for the flags - Added a bunch of defines to the driver bit fields - Reworded the controls and data format descriptions as suggested by Hans - Reworked the controls' structure field size to avoid padding - Removed the long term reference flag - Reintroduced the neighbor info buffer - Removed the ref_pic_list_p0/b0/b1 arrays that are redundant with the one in the DPB - used the timestamps instead of tags - Rebased on 5.0-rc1 Changes from v1: - Rebased on 4.20 - Did the documentation for the userspace API - Used the tags instead of buffer IDs - Added a comment to explain why we still needed the swdec trigger - Reworked the MV col buffer in order to have one slot per frame - Removed the unused neighbor info buffer - Made sure to have the same structure offset and alignments across 32 bits and 64 bits architecture Maxime Ripard (1): media: cedrus: Add H264 decoding support Pawel Osciak (1): media: uapi: Add H264 low-level decoder API compound controls. Documentation/media/uapi/v4l/biblio.rst | 9 +- Documentation/media/uapi/v4l/extended-controls.rst | 547 +++++++++++++- Documentation/media/uapi/v4l/pixfmt-compressed.rst | 20 +- Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 30 +- Documentation/media/videodev2.h.rst.exceptions | 5 +- drivers/media/v4l2-core/v4l2-ctrls.c | 42 +- drivers/media/v4l2-core/v4l2-ioctl.c | 1 +- drivers/staging/media/sunxi/cedrus/Makefile | 3 +- drivers/staging/media/sunxi/cedrus/cedrus.c | 30 +- drivers/staging/media/sunxi/cedrus/cedrus.h | 38 +- drivers/staging/media/sunxi/cedrus/cedrus_dec.c | 13 +- drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 584 ++++++++++++++- drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +- drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 91 ++- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 9 +- include/media/h264-ctrls.h | 190 +++++- include/media/v4l2-ctrls.h | 13 +- include/uapi/linux/videodev2.h | 1 +- 18 files changed, 1627 insertions(+), 3 deletions(-) create mode 100644 drivers/staging/media/sunxi/cedrus/cedrus_h264.c create mode 100644 include/media/h264-ctrls.h base-commit: aa89b613a1c52cfd25076acfbbf6266c4b6f411b -- git-series 0.9.1