Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Feb 2019 14:35:09 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "zhangyi (F)" <yi.zhang@huawei.com>
Cc:     <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
        <miaoxie@huawei.com>
Subject: Re: [PATCH] tracing: fix incorrect tracer freeing when opening
 tracing pipe
Message-ID: <20190220143509.6121f58c@gandalf.local.home>
In-Reply-To: <ed080680-ddac-3e99-720e-a8371fce5ab6@huawei.com>
References: <1550060946-45984-1-git-send-email-yi.zhang@huawei.com>
        <20190213083635.36f4762e@gandalf.local.home>
        <ed080680-ddac-3e99-720e-a8371fce5ab6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 16 Feb 2019 19:19:03 +0800
"zhangyi (F)" <yi.zhang@huawei.com> wrote:

> On 2019/2/13 21:36, Steven Rostedt Wrote:
> > On Wed, 13 Feb 2019 20:29:06 +0800
> > "zhangyi (F)" <yi.zhang@huawei.com> wrote:
> >   
> >> Commit d716ff71dd12 ("tracing: Remove taking of trace_types_lock in
> >> pipe files") use the current tracer instead of the copy in
> >> tracing_open_pipe(), but it forget to remove the freeing sentence in
> >> the error path.
> >>
> >> Fixes: d716ff71dd12 ("tracing: Remove taking of trace_types_lock in pipe files")  
> > 
> > Thanks.
> > 
> > As this is harmless (frees to NULL is ok, and iter is allocated with
> > kzalloc()), I'm going to just add this for the next merge window.
> >   
> 
> This patch patch want to remove kfree(iter->trace) instead of kfree(iter),
> which is set by tr->current_trace and probably not allocated dynamically.
> So if we kfree such tracer in the error path, it will lead to BUG_ON.
> 

This should have been mentioned in the change log. Anyway, I tagged it
for stable, but it will be pulled in during the next merge window, as
that shouldn't be too long from now.

-- Steve