Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Feb 2019 07:50:31 +1100 (AEDT)
From:   James Morris <jmorris@namei.org>
To:     David Howells <dhowells@redhat.com>
cc:     David Laight <David.Laight@ACULAB.COM>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Eric Biggers <ebiggers@google.com>,
        "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KEYS: user: Align the payload buffer
In-Reply-To: <16012.1550671795@warthog.procyon.org.uk>
Message-ID: <alpine.LRH.2.21.1902210750180.1411@namei.org>
References: <6bf441ffc1a54d06ad27ed01c6d06a58@AcuMS.aculab.com> <155066953188.21038.12015964986007814182.stgit@warthog.procyon.org.uk> <16012.1550671795@warthog.procyon.org.uk>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 20 Feb 2019, David Howells wrote:

> David Laight <David.Laight@ACULAB.COM> wrote:
> 
> > I'd make the 'datalen' field 'unsigned int' at the same time.
> > It will use some of the hole you've made and generate better
> > code on most arches.
> 
> Most arches?  I though most, if not all, arches had a load-word instruction.
> 
> Do you want to send me a patch for that?  I'd rather not alter this patch at
> this point.  I can pass the additional patch to James for the next merge
> window.

Should this first one go into -rc?


-- 
James Morris
<jmorris@namei.org>