Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Feb 2019 15:10:44 -0800 (PST)
Subject:     Re: [PATCH 4/6] lib/test_bitmap: switch test_bitmap_parselist to ktime_get()
In-Reply-To: <20190220142048.GA20929@yury-thinkpad>
CC:     andriy.shevchenko@linux.intel.com, yury.norov@gmail.com,
        akpm@linux-foundation.org, Arnd Bergmann <arnd@arndb.de>,
        dmitry.torokhov@gmail.com, keescook@chromium.org,
        willy@infradead.org, mpe@ellerman.id.au, linux@rasmusvillemoes.dk,
        penguin-kernel@I-love.SAKURA.ne.jp, linux-kernel@vger.kernel.org
From:   Palmer Dabbelt <palmer@sifive.com>
To:     yury.norov@gmail.com
Message-ID: <mhng-e872dce6-2abe-467b-b1c1-82a59d4c93e2@palmer-si-x1c4>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 20 Feb 2019 06:20:48 PST (-0800), yury.norov@gmail.com wrote:
> On Wed, Feb 20, 2019 at 03:52:36PM +0200, Andy Shevchenko wrote:
>> On Wed, Feb 20, 2019 at 03:51:01PM +0200, Andy Shevchenko wrote:
>> > On Wed, Feb 20, 2019 at 11:37:03AM +0300, Yury Norov wrote:
>> > > test_bitmap_parselist currently uses get_cycles which is not
>> > > implemented on some platforms, so use ktime_get() instead.
>> >
>> > This sounds like a fix that should go first in the series.
>>
>> Ah, okay, it's already first for test module.
>> Perhaps Fixes tag and actually one or more examples of such architectures?
>
> Hi Andy, thanks for your time on it.
>
> Only arm, arm64, openrisc, riscv and sparc64 #define get_cycles.
> So IIUC, others take stub from include/asm-generic/timex.h.

Should we (RISC-V) be doing something else?  It seems odd to be in such a 
minority here, but we do have a ISA-mandated timer so the get_cycles() 
implementation is super easy.

> sparc32, xtensa, m68k, um, and in some cases x86, mips and nios2
> provide zero-stubs explicitly.
>
> Yury
>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>