Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yue Hu <zbestahu@gmail.com>
To:     akpm@linux-foundation.org, mhocko@suse.com, rientjes@google.com,
        joe@perches.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org, huyue2@yulong.com
Subject: [PATCH] mm/cma_debug: Check for null tmp in cma_debugfs_add_one()
Date:   Thu, 21 Feb 2019 12:01:30 +0800
Message-Id: <20190221040130.8940-2-zbestahu@gmail.com>
In-Reply-To: <20190221040130.8940-1-zbestahu@gmail.com>
References: <20190221040130.8940-1-zbestahu@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Yue Hu <huyue2@yulong.com>

If debugfs_create_dir() failed, the following debugfs_create_file()
will be meanless since it depends on non-NULL tmp dentry and it will
only waste CPU resource.

Signed-off-by: Yue Hu <huyue2@yulong.com>
---
 mm/cma_debug.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/cma_debug.c b/mm/cma_debug.c
index 2c2c869..3e9d984 100644
--- a/mm/cma_debug.c
+++ b/mm/cma_debug.c
@@ -169,6 +169,8 @@ static void cma_debugfs_add_one(struct cma *cma, struct dentry *root_dentry)
 	scnprintf(name, sizeof(name), "cma-%s", cma->name);
 
 	tmp = debugfs_create_dir(name, root_dentry);
+	if (!tmp)
+		return;
 
 	debugfs_create_file("alloc", 0200, tmp, cma, &cma_alloc_fops);
 	debugfs_create_file("free", 0200, tmp, cma, &cma_free_fops);
-- 
1.9.1