Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Feb 2019 09:35:15 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Matt Hsiao <matt.hsiao@hpe.com>
Cc:     linux-kernel@vger.kernel.org, arnd@arndb.de,
        david.altobelli@hpe.com, mark.rusk@hpe.com, jerry.hoemann@hpe.com
Subject: Re: [PATCH 3/4] misc: hpilo: Do not claim unsupported hardware
Message-ID: <20190221083515.GC6397@kroah.com>
References: <1550736282-25416-1-git-send-email-matt.hsiao@hpe.com>
 <1550736282-25416-4-git-send-email-matt.hsiao@hpe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1550736282-25416-4-git-send-email-matt.hsiao@hpe.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 21, 2019 at 04:04:41PM +0800, Matt Hsiao wrote:
> Do not claim when SSID 0x0289 as the iLO features
> are not enabled/validated by the firmware.

Can you put more information here, like _what_ hardware is not being
supported anymore?  As it is, this has nothing to do with "validation by
the firmware", you are just deciding to not support a device that
previously was supported by this driver.  As such you should provide
more information why you are taking away functionality.

thnaks,

greg k-h