Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp324070imp; Thu, 21 Feb 2019 02:08:49 -0800 (PST) X-Google-Smtp-Source: AHgI3IbJEo9YQkXlWfSWn7c+k0taaWpgB4dnKNtoFOyAAcdMnmTY0R5T5jDhf1lLvxz7Qg96Grs9 X-Received: by 2002:a62:fc10:: with SMTP id e16mr40005910pfh.83.1550743729210; Thu, 21 Feb 2019 02:08:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550743729; cv=none; d=google.com; s=arc-20160816; b=LNSW1olUYZDuzKF1V0kZmfnb7/e8dEIaXmxzOE0NyGOtNfgZ4jJn65OpvrhYD7jbc2 Xt2En5BnocAgO2LZByV1NhimkjINnOUw2nTsPGo5/hCeHgdUae/w8TCLfrmpZeW66QI6 QQ1QhOCjUKkfrumrS3ot+LI3pTv4qewy1TzzF9PPSGFgyKyiWTeipZvcNs0hOEHtsqSc /52g45MkF9vYJ7ppCEpUHshJC5VRXTNCbtAKjXKmalG+LXlkSHeOtas3YQnBC2mjIJlL CiOFgN6vcIUfVHgemEKAfU+YOaEqVgM5YwRgUWE/jCktPel589l+KWfT8UknSLH/ZF/r VuRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=74HDA01ZuhzfE/t+K1Yobxx5BIN5qc8lkgw+PBzwH0w=; b=q8nYPcEa+1abRrYXjNIBgrjk5+pvbUKp+p5169eZ48vgzdEchS66n7BG8sL7r9c7yT 3hOmgowQDe87zGSDgonVPr8L0DtmuMZgbbcpoJfhDw2M7hCKSdMAtTMhhQ+A+WjS3oc0 KYEjCbcbEts3oDkrvrO7oPwzzhUn1Rqt0auSQeMvNT+fphDe8FKocwWA87T0Zc10czeD cTljxOgZC/mKdSlR9oDT8htBqG393u40OFfsFuBFoph1zKDB3s1l1xb8XUOG13EhIFNo UTGjJ7It0498SbajacWRwX+yJ7/PgwiGpiGGJJ6i3uGSx9kkz0khMQbzBuMSqAwRauZx Pmsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b="Y9/qrD9C"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e2si16124018pgm.568.2019.02.21.02.08.34; Thu, 21 Feb 2019 02:08:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b="Y9/qrD9C"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727902AbfBUKHe (ORCPT + 99 others); Thu, 21 Feb 2019 05:07:34 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:53114 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726557AbfBUKHd (ORCPT ); Thu, 21 Feb 2019 05:07:33 -0500 Received: by mail-wm1-f65.google.com with SMTP id m1so9659750wml.2 for ; Thu, 21 Feb 2019 02:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=74HDA01ZuhzfE/t+K1Yobxx5BIN5qc8lkgw+PBzwH0w=; b=Y9/qrD9CCe98QX8XY/r+j3afxzu3MvbcBF4NtGCrEETsqDlTUoINgpRoA7ErraLyoA jQ8c5q8hwKZwKE3zRl11vwc0393WtjGrTtICGo99IPH5RZjYVTWX0Sp0tr1ouOQmvIgB tOezwa2LV/V8wldsc3PVzhRqpaNb+rCXspW0oNdVqJRg3oVKJAYaG9axyBWY89ux4O/L LD+6E0PUbXWxJYgCzV+Z+ouxBbDQm/jdNG9e3Zbq1c1gpXeNuKVYPaxIElNoN3CSWa6K 8HRazZNKA0GtryWark0a7ufCOqVldjOG5Md+KqWoNr8I7xw75340Ioe2vldx52kpprep MxyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=74HDA01ZuhzfE/t+K1Yobxx5BIN5qc8lkgw+PBzwH0w=; b=aRtfJcBzODJmtPzbE8oYzLCiZI/jbT7QDmanhz8+n/cnukumX3A/Kj0CI4bh4UUEEU uGZ1cH/Xv/wJjNRSQ7xHRvvenaBlb7gmR2zJWR4+pHB01gxjat3LGK7a3glLY9MmokDz mjEyFE2rz0kog3YVnV+InfWR5XmeFGRvhQZa3OKB62OZ1Z3vmA0qRogDbDtbFXRzXTTt vn6NfSE061uOXYUnsNBcmjAPTK9S3/maFf7msDYizMNfH+KnG0a/IKANW3/xtTjf6XcE KW+eFQEU2GD2Se8sbvWJudDMYGxjvB7zZfLDSKPHbbqKCw9lTr9900GeAGPTQuheL2TD Mqaw== X-Gm-Message-State: AHQUAuZDMmuJZ6d+QCnXoVM2O76p6XXm5WNkyjK+uW8mxe7urp3UzLz+ MrYpiHnkh9iwlSZAT/CNQUzUmZLZiv4= X-Received: by 2002:a1c:7a03:: with SMTP id v3mr9674322wmc.59.1550743651646; Thu, 21 Feb 2019 02:07:31 -0800 (PST) Received: from localhost (ip-89-102-139-73.net.upcbroadband.cz. [89.102.139.73]) by smtp.gmail.com with ESMTPSA id a9sm5938055wmm.10.2019.02.21.02.07.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 02:07:31 -0800 (PST) Date: Thu, 21 Feb 2019 10:57:52 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, "David S. Miller" , Ido Schimmel , open list , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" , jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [PATCH net-next v3 8/8] net: Get rid of switchdev_port_attr_get() Message-ID: <20190221095752.GK2312@nanopsycho> References: <20190221005826.26317-1-f.fainelli@gmail.com> <20190221005826.26317-9-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190221005826.26317-9-f.fainelli@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Feb 21, 2019 at 01:58:26AM CET, f.fainelli@gmail.com wrote: >With the bridge no longer calling switchdev_port_attr_get() to obtain >the supported bridge port flags from a driver but instead trying to set >the bridge port flags directly and relying on driver to reject >unsupported configurations, we can effectively get rid of >switchdev_port_attr_get() entirely since this was the only place where >it was called. > >Signed-off-by: Florian Fainelli Acked-by: Jiri Pirko Thanks!