Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp354935imp; Thu, 21 Feb 2019 02:52:47 -0800 (PST) X-Google-Smtp-Source: AHgI3IbV7Fah1Jcc1HLD0KoGsw2AO5wQRMYP3j93uik1l2OXsVYZRD2VWERWLOkNC75AaEH7ikYi X-Received: by 2002:a17:902:28e9:: with SMTP id f96mr42051176plb.169.1550746367672; Thu, 21 Feb 2019 02:52:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550746367; cv=none; d=google.com; s=arc-20160816; b=HBJqGJo51mxFirKRty7LbxtSxyLTD9j3nrfBMrH1p+TEpLIDMuOCaUtwfWyPEOR+I8 4uQQclpli0c18f1MJVoPNME7GbZjMTcpzQfX+E0E3IGMnZKSojW4Pi0tXzX5lbk+kjTY rACnoFvmw9HzknSSKmj+lugUR3UYGx4mD3DuPLKcRwMd1Vmin9hAzkbON/tWUKOy2JT+ nWOnRLJDNRqfXdwmkL/H9dKb787GDiaCW/pibzpfCQ9FzuPfjJJy45axYOu0zF85LRZy KJMqVDLc2IwEeW2Y48DzSl7ILaLp4pXFI5wzvzGREdMOWG1um5c24wd5Z9qcMXU2MFJH tTng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=x4jdfaVaNCRn2iG7GpiynVl1kZkNsTetILdiIRDww6s=; b=etVtqBtxzoyxYpEw3wyncWZzgKGgB0JHDxK1rzGO2BUF60fGGmiAYJQLJTvf0fWk62 RSUhq2uKQvZoLedbdy1TBe6IopiOa8gsnOGQPZMHYQudcq2syRQ9+uL7ROBpoSX6K5FR KzfTtcc+41WOMKSq2gvm8NNBUzQBDV5oGLh6TJYTe5nat7h18spTVaQtE5CKkoL0jHZr ZkI81DmlJ7Da5lU6nL8H5bO8Kj7UrkAmjnLNEDb+nPGy7tZAMlgcpRib+2W+pHFs3MYo ZWvVL5+6ofPxc9fUEE74KgGEo8T3fMZP5UZaNuTm3RqeQS9Lbt/ZgEW2bweW9E9Nh4EU pJ/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GXmuhlOf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g10si13663163pgk.395.2019.02.21.02.52.31; Thu, 21 Feb 2019 02:52:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GXmuhlOf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727349AbfBUKuI (ORCPT + 99 others); Thu, 21 Feb 2019 05:50:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:56574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfBUKuH (ORCPT ); Thu, 21 Feb 2019 05:50:07 -0500 Received: from localhost (unknown [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD5912085A; Thu, 21 Feb 2019 10:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550746207; bh=UzPbx+4zhvLIEMpbClq8uHK5gFKnQ2FWG/PtwIKyJMY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GXmuhlOfBS8Ft76flrx9W04KSE3BXpSvA+yA6+cnK9N4GYQNvTFxSU3IV8zk6eST5 viDbmnjauXdDaJ5pguJmaL6E/VSqLLuEzW+yR1+MzRjGIy28Q61Ql0mwwdL4LYxkC3 FfpfH/h4Qz6aw8Zn8okfk96SFzHDxWip7SRLpO0Y= Date: Thu, 21 Feb 2019 11:50:01 +0100 From: Boris Brezillon To: "Bean Huo (beanhuo)" Cc: Vignesh R , "Tudor.Ambarus@microchip.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Marek Vasut , Rob Herring , "linux-mtd@lists.infradead.org" Subject: Re: [EXT] [PATCH v6 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Message-ID: <20190221115001.09008681@kernel.org> In-Reply-To: References: <20190212083809.6534-1-vigneshr@ti.com> <20190212083809.6534-3-vigneshr@ti.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Feb 2019 10:41:33 +0000 "Bean Huo (beanhuo)" wrote: > Hi, Vignesh > > > > >Cadence OSPI controller IP supports Octal IO (x8 IO lines), It also has an > >integrated PHY. IP register layout is very similar to existing QSPI IP except for > >additional bits to support Octal and Octal DDR mode. Therefore, extend > >current driver to support Octal mode. Only Octal SDR read (1-1-8)mode is > >supported for now. > > Does this your Cadence OSPI controller support 8-8-8 IO mode, if yes, > Why not directly enable 8-8-8 mode? > Mode 8-8-8 is anyway not supported by the core (see [1] if you need more details). [1]https://patchwork.kernel.org/cover/10638055/