Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.19 01/24] bridge: do not add port to router list when
 receives query with source 0.0.0.0
To:     Hangbin Liu <liuhangbin@gmail.com>,
        Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Ying Xu <yinxu@redhat.com>,
        Roopa Prabhu <roopa@cumulusnetworks.com>,
        "David S. Miller" <davem@davemloft.net>,
        =?UTF-8?Q?Linus_L=c3=bcssing?= <linus.luessing@c0d3.blue>
References: <20181102182839.725385066@linuxfoundation.org>
 <20181102182839.913422845@linuxfoundation.org>
 <07d315a2-d735-3d8b-686c-9c52acf91bf1@newmedia-net.de>
 <20190217164809.GA24091@kroah.com>
 <7978727a-eacc-779c-771f-f4c3013237f3@newmedia-net.de>
 <0425449f-f6d9-c492-d7c8-ba202db88d26@newmedia-net.de>
 <962f3d1f-23eb-647c-74cb-b277212299e7@cumulusnetworks.com>
 <20190220144653.GJ10051@dhcp-12-139.nay.redhat.com>
From:   Sebastian Gottschall <s.gottschall@newmedia-net.de>
Message-ID: <1e412bab-fb07-4b44-eb42-5a74bec12453@newmedia-net.de>
Date:   Thu, 21 Feb 2019 13:50:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190220144653.GJ10051@dhcp-12-139.nay.redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Am 20.02.2019 um 15:46 schrieb Hangbin Liu:
>> Could you please include more details about the setup that's broken ?
>> Note that we were warned[1] of potential breakage from this change
> Sorry I missed Linus's reply after Ying Xu replied. I will read it and
> disscuss with Ying Xu.
>
>> after it went in and regardless of the suggestion from the RFC we'll
>> probably have to revert this patch.
>>
>> Ying Xu as author of the patch, any thoughts ?
> No, we are also waiting for more details from Sebastian.

the test scenario is the following. one of my testers of the dd-wrt 
firmware is using a iptv stream from the france isp "orange".
he just bridged the iptv vlan interface which has no ip (the isp doesnt 
provide a ip configuration here) to a bridge and played with igmp 
snooping to avoid flooding of all ports within the same bridge.
he found out that this setting simply does not work with the current 
kernel, but does
if this patch has been removed. we used kernel 4.4 in the test scenario. 
all latest revision.
i was able to reproduce the same problem on kernel 4.9 and 4.14 on a 
different device using a german isp based iptv stream. same effect. 
after reverting the problematic code it worked again.

Sebastian

>
> Thanks
> Hangbin
>
>> Also adding Linus Lüssing to the CC as he was the one who warned against it.
>> Note that the warning was sent as a reply to my breakage fix, but it was intended
>> for the original patch.
>>
>> Thanks,
>>   Nik
>>
>> [1] https://www.mail-archive.com/netdev@vger.kernel.org/msg272944.html
>>