Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp453442imp; Thu, 21 Feb 2019 04:56:28 -0800 (PST) X-Google-Smtp-Source: AHgI3IYEqxcgiROMsq3Kx4mMFBrvI8aIbOqgmWF4mDUgIAEG46Lha7w6YGa5TWRLoK9HysvogXIT X-Received: by 2002:a63:c54b:: with SMTP id g11mr34308987pgd.441.1550753788617; Thu, 21 Feb 2019 04:56:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550753788; cv=none; d=google.com; s=arc-20160816; b=bu9izfMT+q73cQxmfI8h6eQ/IeEUE8XPB9Xo2tJ8sgri9xzt8Yddd6w+Rjb3Ijo6qK +qMw0MGoFaL28ffnvZR7ByK/aflFXTd61ghqc2GazTgaaQOGjMu7cRG35OlmtibL/QJT ut6OFSSqSwgyhcal38T7rDe8pCQRD+tKWjF6pM/OZ9+y2RJtssfIMQReLy+phF5e+IIu zWeWDPAJ+frHKxI7+ywPoWNk59ik2ty4hAL+v1/gb+k/m0mXcXQpIXjaEkUJ24vTBT08 3c1FSSLkYqui3FZ/muxTNFwsCUyT9NrtvmeCL0sBe3vfN+S7H4tUwDsk3CWKehHpDI+o otmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:date:from:dkim-signature; bh=58z1a8XjpYpJMOkBbFxwfuiRL7Plx4f9fYklUx/AJAI=; b=oQdQ1/Gvp4ca8Vwv/wqdC2Uj2g5I0kVkPYbz7vP0Q8HEfJIGBOWIyut1E3QK+mqFy/ WIuiJMvaOhqYsrBj+DqKf3gEX1sNhtBHqXh9H0I7Ecyo/oxYdPNp0cExeSlfK+9F9AcN d7WR5S4P8F/3PdN9yLwRVkxQ9GK6TCunLqQVAkG0XU50ntMvX3keHpZM93R/XZEqilNH FDMvmRfjrIk0xauxMn54KkeImxsKgCsVMqyf13HXikeH4LwOp0LeI9oXSB/vwYaJ6YgN bN96CNkR1Fbq+Mx6M678vjeGbtN5+ndiqvKJz5roNnKXJz53W94NXeA6VecWM685KzE4 K1kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Y8C5s5zG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 26si8652142pfr.9.2019.02.21.04.56.12; Thu, 21 Feb 2019 04:56:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Y8C5s5zG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfBUMzi (ORCPT + 99 others); Thu, 21 Feb 2019 07:55:38 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:47075 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbfBUMzh (ORCPT ); Thu, 21 Feb 2019 07:55:37 -0500 Received: by mail-lj1-f196.google.com with SMTP id v16so23865142ljg.13 for ; Thu, 21 Feb 2019 04:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=58z1a8XjpYpJMOkBbFxwfuiRL7Plx4f9fYklUx/AJAI=; b=Y8C5s5zG8nwBtt9kjvu17JWDIqJji6K0TVemSQ9NfwNO+0xRdiF0tvcnN/e18kUiED 7JMVvyWbHLJC0dL7ULWyS81DElX3Ic/Cw/7rm8es4AbXHIK7/zASsl7RoPxU/vqtQZOZ 2c+ILq6B9FBmrF3E74LFLyFlhJBD6FHDD3FlgUdhyBf4DFAowopk02QPxOcnX1qZMbHK +XcQoE/biL4pvpzPYb5vFAKu6Pt4crFuypMo8aoHP7wvKk3ViOnk+i81EUthWsM7eew0 h2ytx2IYARMRbsXgnEfp+UkS03FheFEZmaorEzG1dyEF8FZPjiScacNWLaN43+rX9Y8O LF8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=58z1a8XjpYpJMOkBbFxwfuiRL7Plx4f9fYklUx/AJAI=; b=oWcfMl4xCvHX627Od0PZKYiM8mhzjWlf2ZKkumMYHx20IHo8TmLl0cEvQPRCOLlFd0 hm5S9oo8xV1M8ClXEhCIjeEy95Fi7ySFLnrHFcKeBTta1Cf1QwyPvZfuxPIiWaTvXVCs U44sKddviR8AK4V6hPVilXGNzsp7A4S6BO8ByQZNBMVVm/q66os9bu0WtVUv4POOR47K iAJB4zEpatoDlqZ1EH1zHiIUCzZ/fXKpj2mH0mRcv6/GNWasoqoULoSHY3EzP/wKEfX4 9E6NmAJnCMCrruqb7eu8noSBaCVOWoTHSMJCHkKGPyPuuQ3S8S6Z10Cjg9CZ4jgPeY34 tW7A== X-Gm-Message-State: AHQUAuYx/IlqLWl3599IW8x4QGmwf1ogknGoLXEj2ZNPHiWIL6RJ0MrE JeGDkjK+zA3bnRsdx/ZHWMo= X-Received: by 2002:a2e:1510:: with SMTP id s16mr2837816ljd.62.1550753735639; Thu, 21 Feb 2019 04:55:35 -0800 (PST) Received: from localhost ([188.162.52.7]) by smtp.gmail.com with ESMTPSA id q10-v6sm6001307ljh.72.2019.02.21.04.55.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 04:55:34 -0800 (PST) From: Yury Norov X-Google-Original-From: Yury Norov Date: Thu, 21 Feb 2019 15:55:32 +0300 To: Yury Norov Cc: Andy Shevchenko , Andrew Morton , Arnd Bergmann , Dmitry Torokhov , Kees Cook , Matthew Wilcox , Michael Ellerman , Rasmus Villemoes , Tetsuo Handa , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] lib/test_bitmap: switch test_bitmap_parselist to ktime_get() Message-ID: <20190221125532.GA6934@yury-thinkpad> References: <20190220083705.14050-1-ynorov@marvell.com> <20190220083705.14050-5-ynorov@marvell.com> <20190220135101.GU9224@smile.fi.intel.com> <20190220135236.GV9224@smile.fi.intel.com> <20190220142048.GA20929@yury-thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220142048.GA20929@yury-thinkpad> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2019 at 05:20:48PM +0300, Yury Norov wrote: > On Wed, Feb 20, 2019 at 03:52:36PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 20, 2019 at 03:51:01PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 20, 2019 at 11:37:03AM +0300, Yury Norov wrote: > > > > test_bitmap_parselist currently uses get_cycles which is not > > > > implemented on some platforms, so use ktime_get() instead. > > > > > > This sounds like a fix that should go first in the series. > > > > Ah, okay, it's already first for test module. > > Perhaps Fixes tag and actually one or more examples of such architectures? > > Hi Andy, thanks for your time on it. > > Only arm, arm64, openrisc, riscv and sparc64 #define get_cycles. > So IIUC, others take stub from include/asm-generic/timex.h. > > sparc32, xtensa, m68k, um, and in some cases x86, mips and nios2 > provide zero-stubs explicitly. I forgot about Fixes tag: Fixes: 6df0d464dbcc1a5 ("lib/test_bitmap.c: add test for bitmap_parselist()") If it comes to v3, I'll add the tag and explanations above to the patch message.