Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp539532imp; Thu, 21 Feb 2019 06:29:53 -0800 (PST) X-Google-Smtp-Source: AHgI3IaUNZVTYu8WO+U94oHaOxAy8JFgwp05vwUTRqJhCxRzo/PkR/OG/U3hS8Ax4OugBoQs+ks5 X-Received: by 2002:a17:902:32b:: with SMTP id 40mr41361682pld.327.1550759393778; Thu, 21 Feb 2019 06:29:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550759393; cv=none; d=google.com; s=arc-20160816; b=BgsZw7I+3oqMj5k+1e6i3KD1KL3A7hgb7Lonjcd3V3TkPIoNp/kgVfd3Rf068DpXZ0 gzJAGQ5G1zrkuF8/sQFAysEKd8ftn0HqSAUFgaMobSsAlFVDpHnIyZ4Z8OSHH4/1tRc/ UManxik9XbEujX0pWRc6VNl939rQkVsOHFIxGiHrKnaXA6vCE+pIxC2R6rOSpwkKAurW DyEsIL+N47mKmwYJxl9d6QQBuSeXAbOeg11cb4C+bE0xomCos4sLEBTUL5yjqn/4CjAM Urtn37cv0ARez7rqD493jNZQWd4Ei4xcQ4+TWNQ0CSDzmRQe5LK9NX3oD6ocQFeIseCA vAWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=tHFrjYbJjzzsBN4FCSQLd4n9P2bn+tCZVe8ylQfXhW4=; b=t7TLBnlmUONr/I0otpV2sduRiqlb3kOIbvlwNaIBoKTfOSaumiUTeTy89Uz3Q5HhzD dJPIprqBoukMbtmEoF42qMseEShvij2R+KDsS9gWYystBzFyeeVGlMaCrbeGpp1tjjba GxLCnFC3HI1G/S02b0fTF4NbrmgQO8TstnEmguIWxdVTV0g7hP1TizKbDojZWKryvDLU fryGulyb8dGiSoqfwIygfKxBZ7JrQhlhqZDTUarGcM0xFO380PO8boUmrOupAEVBDs0p avtUyWCfHXDJDP0Y6mtxxkJpphDgFP4b+6+W3G91+Eg2Riz3dl7/fBmjDw4tZxNvr4Re CEWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="K77ZsW/1"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si19917631pgo.356.2019.02.21.06.29.38; Thu, 21 Feb 2019 06:29:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="K77ZsW/1"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727901AbfBUO2y (ORCPT + 99 others); Thu, 21 Feb 2019 09:28:54 -0500 Received: from mail-yw1-f65.google.com ([209.85.161.65]:43729 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbfBUO2x (ORCPT ); Thu, 21 Feb 2019 09:28:53 -0500 Received: by mail-yw1-f65.google.com with SMTP id u200so10689139ywu.10 for ; Thu, 21 Feb 2019 06:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tHFrjYbJjzzsBN4FCSQLd4n9P2bn+tCZVe8ylQfXhW4=; b=K77ZsW/1oNEw7xTFnPDR0RuFvHgeW6FdGNATC5dH+D/lhNHAmQjJ82cHxWZ5oFBsu3 R4vhTpGOHomnuoKAI7LKvhyWI+pVdupoehTixVwngliAI0oZ89+4Yrv+TJ7khWBrlrBp pXtF64Bo4jyVNgR6XACt4eabJkJRxOebjUgw9G8wdM0aAklRQCy/j/PiTD7SA1KJYy8t Bs4Wl2xxP4DN242zy2S/d8AFfE4MbIW+SWoaK0Z//HV0GzvI7as8MfcI09rxrYYRKyU3 gA2pHgG0frwS7oazG5eJzYN/lEohKJ5EmjzLPHAzimaUaKesw5mS7wD2L01StdER8tQZ uy/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tHFrjYbJjzzsBN4FCSQLd4n9P2bn+tCZVe8ylQfXhW4=; b=P1dgniJbFANTuU7KY1U4nkMi9HsmLHzeahcQtVpgykomKlF9/lP1p9EMPPWOz2IaBY 2rEPI3h+OGI+Tmqs675rQZcr+XukKOR7a8Yu1xlGSfDo8s5hJ0hodCGtFBhifsttSUGc ozFKjuxTn93IMzqNQiXaU9QmASSKAml+sE5v0IboJqO7+FTaBJw2vNWJC2HDTTIWa4Lz jj8bDbEovH9+GeA9EgujNb0WaoqThWTQrSa05pfpodES0NPOZLzPWY/hUYyQLszbh7b5 0+usRrUIik2eOktqiJGbQEKi0VjewaoV4Jcq3jbZkl56NSZVSVQl3YfiRxBFumtegOCI yyYA== X-Gm-Message-State: AHQUAublETXix9yNF8D6GDAMjyLmdSS9E2n7PaxHdVVW3kMTMbKjdFr8 ag1hq1zCOkNd6oU13ZnUeIg= X-Received: by 2002:a0d:e703:: with SMTP id q3mr21978097ywe.382.1550759333059; Thu, 21 Feb 2019 06:28:53 -0800 (PST) Received: from localhost.localdomain ([191.101.9.198]) by smtp.gmail.com with ESMTPSA id b7sm9420776ywa.86.2019.02.21.06.28.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 06:28:52 -0800 (PST) From: Bo YU To: gaoxiang25@huawei.com, yuchao0@huawei.com, gregkh@linuxfoundation.org, yuzibode@126.com Cc: Bo Yu , linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs Date: Thu, 21 Feb 2019 09:28:45 -0500 Message-Id: <20190221142845.13604-1-tsu.yubo@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bo Yu Fix sparse warnings: drivers/staging/erofs/utils.c:134:6: warning: symbol 'erofs_try_to_release_workgroup' was not declared. Should it be static? Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled") Cc: Gao Xiang Cc: Chao Yu CC: Greg Kroah-Hartman Signed-off-by: Bo Yu --- drivers/staging/erofs/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c index b535898ca753..33cd5ad55cb8 100644 --- a/drivers/staging/erofs/utils.c +++ b/drivers/staging/erofs/utils.c @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp) __erofs_workgroup_free(grp); } -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi, +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi, struct erofs_workgroup *grp, bool cleanup) { -- 2.11.0