Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared
 symbols in erofs
To:     Bo YU <tsu.yubo@gmail.com>
CC:     <yuchao0@huawei.com>, <gregkh@linuxfoundation.org>,
        <yuzibode@126.com>, <linux-erofs@lists.ozlabs.org>,
        <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
        Miao Xie <miaoxie@huawei.com>,
        "fangwei (I)" <fangwei1@huawei.com>
References: <20190221142845.13604-1-tsu.yubo@gmail.com>
From:   Gao Xiang <gaoxiang25@huawei.com>
Message-ID: <05254fc6-6bd7-7c30-cfcc-2ddff4ac13b6@huawei.com>
Date:   Thu, 21 Feb 2019 22:35:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20190221142845.13604-1-tsu.yubo@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Bo,

On 2019/2/21 22:28, Bo YU wrote:
> From: Bo Yu <tsu.yubo@gmail.com>
> 
> Fix sparse warnings:
> 
> drivers/staging/erofs/utils.c:134:6: warning: symbol
> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
> 
> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
> Cc: Gao Xiang <gaoxiang25@huawei.com>
> Cc: Chao Yu <yuchao0@huawei.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
> ---
>  drivers/staging/erofs/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
> index b535898ca753..33cd5ad55cb8 100644
> --- a/drivers/staging/erofs/utils.c
> +++ b/drivers/staging/erofs/utils.c
> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>  	__erofs_workgroup_free(grp);
>  }
>  
> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>  				    struct erofs_workgroup *grp,
>  				    bool cleanup)
>  {
> 

Have you looked the latest kernel code?
It seems erofs_try_to_release_workgroup is already be claimed as static...

See:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148

Thanks,
Gao Xiang