Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp617764imp; Thu, 21 Feb 2019 07:54:49 -0800 (PST) X-Google-Smtp-Source: AHgI3IakRSHCuSF+0HnvVg5mAXrIuABLKVdG+qIyWAQUkG4oxD+47awO+GvSBdAUhtvdfuMLPUkc X-Received: by 2002:a65:63c1:: with SMTP id n1mr21675686pgv.339.1550764489673; Thu, 21 Feb 2019 07:54:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550764489; cv=none; d=google.com; s=arc-20160816; b=zAhGaqkIzRIQj33E+gbdZWfK1GQjh1SHcsf+8auLU7V2hHpSo3Q8w4kCCJZEkuJy+x 2bVNlYBTlUnKJ3F23f/nDi3HO3JrmWI06nD6iGPBmJ127ql7DZnrVt4Pd50Kiz/RUbW2 BU0PEycz2T/Vg4yUH64Kl4O4bbXhZ+WZBCVNqu3UXoDVdSZSvCB8wD4tkS6UkGA+z5e/ EUl0DLl8FzK3jUjpRMJUS1wjmE3cd9JntMJQfkkChuAzaxg5GsZjPjXiETtE2Mn4IG74 4t/+5PsX04f4kcBLsdSfg69l4AUri+xjcU+lXDWcvgmtuH3cipVJNkvPuoqtOwaonyDm lYcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=ozRxzMurU21w48JYprR849vMNJMRBbFGSCgknsgpXk0=; b=mLiLLMTUjf5TxO907xAvD8K7VBST588IqcvDPBdrjtVf1V5uN74V+R8iUyEa/J7Hgi g9t+LMuItb65IDZq91ZejQPF6fZRTXQhga8hQdgm+IEFsBGYxA8CVUxHKFPetIeO+e/i 9NHlDrmme7f96VjCsRf1V9j7qwaX7AmHQijEjHk1vHsvYiOh26CDZyOePQ4HTK7Q3mr2 kJbuVr9sJ8nkUtLeQS5mF2aElRjSvvJoHan04HZ9LgWZU6Vf+uVxW30UYqGzgJjdPgfp 1J0ySoFUilvwpXsTHY/ajOK9iTOUovbCTwdeYMVQQytNN00YD08tSES0GEL+rtbaZBh/ VOVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=selector1 header.b=cvlt0b77; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j97si5894008plb.292.2019.02.21.07.54.33; Thu, 21 Feb 2019 07:54:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=selector1 header.b=cvlt0b77; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728529AbfBUPwd (ORCPT + 99 others); Thu, 21 Feb 2019 10:52:33 -0500 Received: from mail-eopbgr720101.outbound.protection.outlook.com ([40.107.72.101]:56750 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726344AbfBUPwa (ORCPT ); Thu, 21 Feb 2019 10:52:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ozRxzMurU21w48JYprR849vMNJMRBbFGSCgknsgpXk0=; b=cvlt0b77vLDw4LntM0K6Wpmsm4SYqoHL1BsejUNWyhnlazfzorsWIcd6c3TWP83Jt4czvleGbOccr+Aibr79InDOnjxNKqciHA+1A8Kxnlswlymgra19XLCMaGXf2FVV5aucjJhujv3eZfTSxLyJPE6Igu8pakPblhj3sKl/9Yw= Received: from DM5PR0102CA0007.prod.exchangelabs.com (2603:10b6:4:9c::20) by DM6PR01MB3995.prod.exchangelabs.com (2603:10b6:5:92::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Thu, 21 Feb 2019 15:52:22 +0000 Received: from CO1NAM03FT059.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e48::206) by DM5PR0102CA0007.outlook.office365.com (2603:10b6:4:9c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15 via Frontend Transport; Thu, 21 Feb 2019 15:52:22 +0000 Authentication-Results: spf=pass (sender IP is 18.9.28.11) smtp.mailfrom=mit.edu; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=mit.edu; Received-SPF: Pass (protection.outlook.com: domain of mit.edu designates 18.9.28.11 as permitted sender) receiver=protection.outlook.com; client-ip=18.9.28.11; helo=outgoing.mit.edu; Received: from outgoing.mit.edu (18.9.28.11) by CO1NAM03FT059.mail.protection.outlook.com (10.152.81.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.13 via Frontend Transport; Thu, 21 Feb 2019 15:52:22 +0000 Received: from callcc.thunk.org (guestnat-104-133-8-109.corp.google.com [104.133.8.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x1LFqJDb025351 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Feb 2019 10:52:20 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id BD4F07A3F79; Thu, 21 Feb 2019 10:52:18 -0500 (EST) Date: Thu, 21 Feb 2019 10:52:18 -0500 From: "Theodore Y. Ts'o" To: Mathieu Malaterre CC: Andreas Dilger , , Subject: Re: [PATCH 2/2] ext4: annotate implicit fall throughs Message-ID: <20190221155218.GD4062@mit.edu> Mail-Followup-To: "Theodore Y. Ts'o" , Mathieu Malaterre , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190114203945.20233-1-malat@debian.org> <20190114203945.20233-2-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190114203945.20233-2-malat@debian.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:18.9.28.11;IPV:CAL;SCL:-1;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(376002)(39860400002)(396003)(346002)(136003)(2980300002)(189003)(199004)(106002)(5660300002)(36756003)(316002)(16586007)(42186006)(54906003)(1076003)(50466002)(46406003)(76176011)(58126008)(36906005)(186003)(786003)(26005)(336012)(90966002)(4326008)(23726003)(52956003)(305945005)(86362001)(103686004)(126002)(446003)(476003)(246002)(486006)(356004)(47776003)(229853002)(2906002)(11346002)(88552002)(6916009)(97756001)(2616005)(106466001)(33656002)(26826003)(14444005)(6246003)(6266002)(75432002)(4744005)(8676002)(8936002)(478600001)(18370500001)(42866002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR01MB3995;H:outgoing.mit.edu;FPR:;SPF:Pass;LANG:en;PTR:outgoing-auth-1.mit.edu;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 631dab5a-74da-4e84-1ec3-08d698149161 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4608103)(4709054)(2017052603328)(7153060);SRVR:DM6PR01MB3995; X-MS-TrafficTypeDiagnostic: DM6PR01MB3995: X-LD-Processed: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;DM6PR01MB3995;20:5B7EtBcfUXxek44m6Cb9yHTjJJK/DylJWJ9GBscklv1qk0tDE8ZyOL9Fmtru9a0CeAMCSXktH50Uk/Pl93t86+t6utW3SqadE2GU1ZqRvS8YLd2SK//wUx11Ra5UaGvpE5EIbOtrsQ1CyIARCKtQH5ZCo6tRfJYmLTASg7iIyu9UptWEXJZi2qMdeU8cykRUtfGoybsbCE12C6T6LLP6EvNFepGUu10pM0w906Qs3sR57dflP6lp8xIStKHQKFDb+DdBEoeCgtchfvgnf4OA+3c0bPHzxXKAtJy2Gq3T8k3TKgWfBbzRHxzy3FR62x12B1NuEBiwEjxvZolae8mLwzp/Kdg7t22LxGHaHdGi8RQl188kSaJYmknGDkPPexjj7NLNz0dwS1Pb9He5zdBFn7O7zaMOpWC+817cG8EYsut6sjLxdf0rvK3IGH5jgE+qbjx+FW8/ICKQLVeVXfrVTWX8Q0k+WsDQymVWQTG1f829S9aWVoOmEBc0PsGHVk17gu5O6MCPAgglu2uDi/n/CyiLltgqfIbhFuHbJWMOnDL+p8kUgKaA7MthAkTowHH+jRWkRZU/f4tbg2yhK7h1cM2XzkNpL0JllBTO025f/Hg= X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 09555FB1AD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM6PR01MB3995;23:gFhQ+8ZDzpQjEs5tHN4LEZNL0RKhfVxRKr6lK+MoQ?= =?us-ascii?Q?gp6Wc7W4+LgGO6QQ1n9QuC/GJUAAulIMm62EZqBy6eadsAKpq9O96734RtcO?= =?us-ascii?Q?lfA9SLxzK4iI/jF37cpilCuMDbFSYUv9x/TmSsOvFNmKk6w7/iFhOzZ+jrKJ?= =?us-ascii?Q?G6FSCLkhO1eYSFzKho6LEsSEizqxWfLlwPhgcplFNgOoMQ1GCmxBD1kzNW11?= =?us-ascii?Q?wYzoIYPo1Z51+yOKCputmdLIP4tngV9wRBg4fwEUQqqllsRyheCnu/m+X0wN?= =?us-ascii?Q?VuYXGC/zFWU+u2MHqXKi+Y8w8xpsNxbBi8+zNwXDhtXR8KWcnU2elwDyQcc5?= =?us-ascii?Q?+9Oaf3aZSRH1pEJ76tE2fAkKYAjG4wWTmssbuk0St04hwpyh8UcUS8z/TXus?= =?us-ascii?Q?9C2FUnEFxzgNm6NF2XFJBkC1WloDSqvgcaT3WGZ7Btb3IBZDyKQbOYByVkAf?= =?us-ascii?Q?DQJHBMpEAyYIdRzaJvPoNM/fM+FNEvkufpZ0HPrGlvet9MImTCy++ts7etdz?= =?us-ascii?Q?maZGP6tVSx5gZYAaFQd5vX4UdasaOReC8eIPmrmPgCHEbLMMojQPieuhf0ao?= =?us-ascii?Q?wpZUlxfOJi1LhEJPRdqDvjF0oW1IcRjnufLSPOmLvFYWY/qKgRy1gO7VYfGO?= =?us-ascii?Q?gFWvfGMINuO8UGrAHnht3rKBQSsw+THRBo12UH6IOV2OqbqCoS6gwBXpK5fC?= =?us-ascii?Q?WEhQ2sUeStLrK8LUAAEBA9R5AGMTS6cJairL/ngNSWanw8jlCqq9DjG+UfN7?= =?us-ascii?Q?P1WK/URTK7MfzZvQLYUQTSYPRjmsyuvgAsNHLM2NEp1sLphksWAOZLPryNRf?= =?us-ascii?Q?2kWBM7LffVJP9p0oy5kT66cVw3W3jv1TgyK6CjWx3y7dW+uSoiA+VpTiuHHb?= =?us-ascii?Q?0huTCiP2TOVVWVB7w5FAexzcuFwzs56+WONcXPmd7i6K9vURWNZHsykBK5yL?= =?us-ascii?Q?dtODt6M3Y6+MHSnk5xjxxSFMV/vNJT2d0EofGwolg03Wehj0zAtaZAgQHjI1?= =?us-ascii?Q?ZaOKIGaZOTtnVbDkKLUkoc2Q+cvAUqkqNMAfwvJa7JTIRHYko4a8Oz4ms5RQ?= =?us-ascii?Q?HzQoOiKGDUdtfnjfZK7xHHJn1HVZuGxA1z3Yypfua6oRyliCIgnKg/CILRXK?= =?us-ascii?Q?VKXt3i+rHAiE76tfdqqxE4hJ1YQMMta4nFP1E3TPekyK+brYnTvYPtenvNwV?= =?us-ascii?Q?7odouzKX/Knmd8lVlq7LnyWmTK+gC2hRcMONZ15sLssntWHAofKXdtSZyAwP?= =?us-ascii?Q?cEK4AlUL2OTV6PJMS7Bk+TnY09krxUkVCpn8K5xZ9np13l0W8xI4wdOBZ8cC?= =?us-ascii?B?QT09?= X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: TCmpp+TZcjZsy+/PskmH3Dv0XEI1gCj1JLzHXJxEPGC0DAUUiMg61JgLlXSC7JV5f0hsLtPW0qnJSSTUhOhPB8nXumW+NShMM9Rgo3u8fij/3gciAGOjhkuUZBBGD/0D5LtMM5zVaxfKWvHG/l18vMqNhxRaHbfKNTKxUF4MtajyJDqzPLLX9Qguoh5xWv45XmqR3LyijFHwwjSScjVmWzte0h9W522ZavmQNcFRlKTL5n0Vvdo1aILwCOIrfF5If4P4e4ooWNj8BM+QPc4InEXZZNTFt+5J812ZK8vqhboXmu/jNU8+Q+pFVHk6qjO6pRtd8bZFYnw+mmqVzk4x01sYL/U+7EFASvS7vBY4llGulF87sPjRLjAmeJGm6AwLBLBSzFRB2bSsJNNhskhNMNZk0WliFacxh0XiuKbLkTE= X-OriginatorOrg: mit.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2019 15:52:22.0819 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 631dab5a-74da-4e84-1ec3-08d698149161 X-MS-Exchange-CrossTenant-Id: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=64afd9ba-0ecf-4acf-bc36-935f6235ba8b;Ip=[18.9.28.11];Helo=[outgoing.mit.edu] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB3995 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 14, 2019 at 09:39:44PM +0100, Mathieu Malaterre wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and > these places in the code produced warnings (W=1). Fix them up. > > This commit remove the following warnings: > > fs/ext4/indirect.c:1182:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > fs/ext4/indirect.c:1188:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > fs/ext4/indirect.c:1432:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > fs/ext4/indirect.c:1440:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Mathieu Malaterre Thanks, applied. - Ted