Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp678176imp; Thu, 21 Feb 2019 09:01:51 -0800 (PST) X-Google-Smtp-Source: AHgI3IZjgUdagd5Vxn6sANxhWRGSmygtC1Wv7HkKmqy1XuOrlacwYVr0cU+b8AVle37ZIq0OFpzN X-Received: by 2002:a63:1947:: with SMTP id 7mr11173874pgz.279.1550768511819; Thu, 21 Feb 2019 09:01:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550768511; cv=none; d=google.com; s=arc-20160816; b=nS7NQB5JrAouF3hU+1oo2SC6uJLIlysURtpwB6RqsfseTlWNk4gKd7BYtqsG7CIzXs btCNu9l8j/cPEm+UtiL7Xytq/57hqq4U81BcqvOzsc7l7E65rjW2ef4B5RiyDYsmdLh+ U0mEP/Qz/caO2tvvledDKP9gnWEWAuudP+JFc9LAn023EaojOHJpBaMXFHqfEjsVBFsM 5StwpkAH4Ne4hVaUWLBVwYjQmkL0UPEaDEd2tQgv7gdFr+zBpVX7bwHtQtIdtncwgUlw 2HL0qwWKcHRW2U7CrspuLzUQZO/7w4PJyCD0mbzaUvOMoCY8m4zVmE9L6NiZSZJlRd+V xYZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:date:cc:to:from:subject :message-id; bh=ukassX4yKuuFkawf9dmAFt+HS5MkvXQ2AO91Mzq/PWY=; b=woyEgSfEtlC595L9tLJwmr/78M14T7k9tZ3Px0uD3qQ+B+RwV59YZaj8Dsh1fw5DmP fI7fACboNzOa4g5faJ84u06gc3fm0uNkFyjnbSg3QPgUP2a6BCxEbr7JNIId2GUq6jaO T0yeikhIw8E772RGlyiWFd7iybcC2OMB+SrHo1mkqnH2nRoCTQjiI5m5E01ys73QOYaP IFRg/ipaBMbFKD/tV/ePHV319waVDWr309R04R8380fkwYjYKUqB2slf4W1vvtSwt1mO 8ZdwkahILJ9NlKHyWmixwGiFtqcoZO7q3wtIXPdv9PeD2Forcwf0k+KHQJNbq1op+7XE mCJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a19si6770678plm.128.2019.02.21.09.01.32; Thu, 21 Feb 2019 09:01:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbfBURAp (ORCPT + 99 others); Thu, 21 Feb 2019 12:00:45 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:43221 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbfBURAp (ORCPT ); Thu, 21 Feb 2019 12:00:45 -0500 Received: from [167.98.27.226] (helo=xylophone) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1gwriD-00075H-7D; Thu, 21 Feb 2019 17:00:41 +0000 Message-ID: <1550768440.2925.259.camel@codethink.co.uk> Subject: Re: [PATCH stable-4.4.y] KVM: VMX: Fix x2apic check in vmx_msr_bitmap_mode() From: Ben Hutchings To: Greg Kroah-Hartman , Joerg Roedel Cc: Joerg Roedel , stable@vger.kernel.org, David Woodhouse , Paolo Bonzini , Jim Mattson , linux-kernel@vger.kernel.org Date: Thu, 21 Feb 2019 17:00:40 +0000 In-Reply-To: <20190221162032.GF25800@kroah.com> References: <20190221135213.23926-1-joro@8bytes.org> <20190221141530.GA18436@kroah.com> <20190221144701.GB8380@suse.de> <20190221162032.GF25800@kroah.com> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-02-21 at 17:20 +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 21, 2019 at 03:47:01PM +0100, Joerg Roedel wrote: > > On Thu, Feb 21, 2019 at 03:15:30PM +0100, Greg Kroah-Hartman wrote: > > > Ugh, good catch! > > > > > > Any hint as to what type of testing that you did that caught this?  I > > > keep asking people to run some kvm tests, but so far no one is :( > > > > We caught this at SUSE while testing candidate kernel updates for one of > > our service packs using a 4.4-based kernel and debugging turned > > out that this is issue came in via stable-updates. We also build a > > vanilla-flavour of the kernel which is nearly identical to the upstream > > stable tree, but what usually ends up in testing is the full tree with > > other backports. > > > > This particular issue was found by updating some openstack machines with > > the candidate kernel, which then triggered the problem in some guests. > > It is also a very special one, since I was only able to trigger the > > problem on Westmere-based machines with a specific guest-config. > > Nice work.  Any chance that "test" could be added to the kvm testing > scripts that I think are being worked on somewhere?  Ideally we would > have caught this before it ever hit the stable tree. If I understood correctly, the bug is specific to my backport. > Due to the lack of > good KVM testing, that's one of the areas I am always most worried about > :( Since the behaviour in this area depends on the host CPU model this might not help much. Ben. -- Ben Hutchings, Software Developer   Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom