Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262745AbUCOUkG (ORCPT ); Mon, 15 Mar 2004 15:40:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262747AbUCOUkG (ORCPT ); Mon, 15 Mar 2004 15:40:06 -0500 Received: from mx1.redhat.com ([66.187.233.31]:62374 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262745AbUCOUkB (ORCPT ); Mon, 15 Mar 2004 15:40:01 -0500 Date: Mon, 15 Mar 2004 12:39:53 -0800 From: "David S. Miller" To: Tom Rini Cc: cieciwa@alpha.zarz.agh.edu.pl, linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: [SPARC64][PPC] strange error .. Message-Id: <20040315123953.3b6b863f.davem@redhat.com> In-Reply-To: <20040315190026.GG4342@smtp.west.cox.net> References: <20040315190026.GG4342@smtp.west.cox.net> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 17 On Mon, 15 Mar 2004 12:00:26 -0700 Tom Rini wrote: > That leaves the more general problem of uses 'asmlinkage' > on platforms where either (or both) of the following can be true: > - 'asmlinkage' is a meaningless term, and shouldn't be used. > - doesn't include so it's possible > another file down the line breaks. I think the best fix is to include linux/linkage.h in asm/unistd.h as you seem to be suggesting, and therefore that is the change I will push off to Linus to fix this on sparc32 and sparc64. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/