Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Cc:     <bhelgaas@google.com>, <Austin.Bolen@dell.com>,
        <keith.busch@intel.com>, <Shyam.Iyer@dell.com>, <okaya@kernel.org>,
        <linux-pci@vger.kernel.org>, <rafael.j.wysocki@intel.com>,
        <andy.shevchenko@gmail.com>, <mika.westerberg@linux.intel.com>,
        <poza@codeaurora.org>, <linux-kernel@vger.kernel.org>
From:   <Alex_Gagniuc@Dellteam.com>
To:     <lukas@wunner.de>, <mr.nuke.me@gmail.com>
Subject: Re: [PATCH RFC v2 1/4] PCI: hotplug: Add support for disabling
 in-band presence
Thread-Topic: [PATCH RFC v2 1/4] PCI: hotplug: Add support for disabling
 in-band presence
Thread-Index: AQHUyLqYrzwot6C9Ik6lskQh1EhBRQ==
Date:   Thu, 21 Feb 2019 18:05:22 +0000
Message-ID: <842e01310e894fd695b213652efdede7@ausx13mps321.AMER.DELL.COM>
References: <20190220012031.10741-1-mr.nuke.me@gmail.com>
 <20190220012031.10741-2-mr.nuke.me@gmail.com>
 <20190221071946.poqwdilfijpafhvb@wunner.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/21/19 1:20 AM, Lukas Wunner wrote:=0A=
> =0A=
> [EXTERNAL EMAIL]=0A=
> =0A=
> On Tue, Feb 19, 2019 at 07:20:27PM -0600, Alexandru Gagniuc wrote:=0A=
>> @@ -846,6 +846,9 @@ struct controller *pcie_init(struct pcie_device *dev=
)=0A=
>>   	if (pdev->is_thunderbolt)=0A=
>>   		slot_cap |=3D PCI_EXP_SLTCAP_NCCS;=0A=
>>   =0A=
>> +	if (pdev->no_in_band_presence)=0A=
>> +		ctrl->inband_presence_disabled =3D 1;=0A=
>> +=0A=
>>   	ctrl->slot_cap =3D slot_cap;=0A=
>>   	mutex_init(&ctrl->ctrl_lock);=0A=
>>   	mutex_init(&ctrl->state_lock);=0A=
> =0A=
> The above hunk belongs in patch 4.=0A=
> =0A=
> =0A=
>> --- a/include/linux/pci.h=0A=
>> +++ b/include/linux/pci.h=0A=
>> @@ -413,6 +413,7 @@ struct pci_dev {=0A=
>>   	unsigned int	non_compliant_bars:1;	/* Broken BARs; ignore them */=0A=
>>   	unsigned int	is_probed:1;		/* Device probing in progress */=0A=
>>   	unsigned int	link_active_reporting:1;/* Device capable of reporting l=
ink active */=0A=
>> +	unsigned int	no_in_band_presence:1;	/* Device does not report in-band =
presence */=0A=
>>   	unsigned int	no_vf_scan:1;		/* Don't scan for VFs after IOV enablemen=
t */=0A=
>>   	pci_dev_flags_t dev_flags;=0A=
>>   	atomic_t	enable_cnt;	/* pci_enable_device has been called */=0A=
> =0A=
> Same here.=0A=
=0A=
:)=0A=
=0A=
> Thanks,=0A=
> =0A=
> Lukas=0A=
> =0A=
=0A=