Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262755AbUCOU5I (ORCPT ); Mon, 15 Mar 2004 15:57:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262754AbUCOU4r (ORCPT ); Mon, 15 Mar 2004 15:56:47 -0500 Received: from fw.osdl.org ([65.172.181.6]:9687 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262751AbUCOU4p (ORCPT ); Mon, 15 Mar 2004 15:56:45 -0500 Date: Mon, 15 Mar 2004 12:54:17 -0800 From: "Randy.Dunlap" To: Tom Rini Cc: davem@redhat.com, cieciwa@alpha.zarz.agh.edu.pl, linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: [SPARC64][PPC] strange error .. Message-Id: <20040315125417.3839f8fa.rddunlap@osdl.org> In-Reply-To: <20040315204346.GB13167@smtp.west.cox.net> References: <20040315190026.GG4342@smtp.west.cox.net> <20040315123953.3b6b863f.davem@redhat.com> <20040315204346.GB13167@smtp.west.cox.net> Organization: OSDL X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) X-Face: +5V?h'hZQPB9kW Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 31 On Mon, 15 Mar 2004 13:43:46 -0700 Tom Rini wrote: | On Mon, Mar 15, 2004 at 12:39:53PM -0800, David S. Miller wrote: | | > On Mon, 15 Mar 2004 12:00:26 -0700 | > Tom Rini wrote: | > | > > That leaves the more general problem of uses 'asmlinkage' | > > on platforms where either (or both) of the following can be true: | > > - 'asmlinkage' is a meaningless term, and shouldn't be used. | > > - doesn't include so it's possible | > > another file down the line breaks. | > | > I think the best fix is to include linux/linkage.h in asm/unistd.h as | > you seem to be suggesting, and therefore that is the change I will | > push off to Linus to fix this on sparc32 and sparc64. | | Erm, if I read include/asm-sparc{,64}/linkage.h right, 'asmlinkage' ends | up being defined to ''. So why not just remove 'asmlinkage' from the | offending line in unistd.h ? For future-proofing: so that it will be like all other $arch/unistd.h, so that when someone changes the meaning of it, it will just work...? -- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/