Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262796AbUCOVRW (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 15 Mar 2004 16:17:22 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262795AbUCOVQx
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 15 Mar 2004 16:16:53 -0500
Received: from fw.osdl.org ([65.172.181.6]:35047 "EHLO mail.osdl.org")
	by vger.kernel.org with ESMTP id S262769AbUCOVQs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Mar 2004 16:16:48 -0500
Date: Mon, 15 Mar 2004 13:14:21 -0800
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Tom Rini <trini@kernel.crashing.org>
Cc: davem@redhat.com, cieciwa@alpha.zarz.agh.edu.pl,
       linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [SPARC64][PPC] strange error ..
Message-Id: <20040315131421.5ac234e1.rddunlap@osdl.org>
In-Reply-To: <20040315210807.GC13167@smtp.west.cox.net>
References: <Pine.LNX.4.58L.0403151437360.16193@alpha.zarz.agh.edu.pl>
	<Pine.LNX.4.58L.0403151939460.17732@alpha.zarz.agh.edu.pl>
	<20040315190026.GG4342@smtp.west.cox.net>
	<20040315123953.3b6b863f.davem@redhat.com>
	<20040315204346.GB13167@smtp.west.cox.net>
	<20040315125417.3839f8fa.rddunlap@osdl.org>
	<20040315210807.GC13167@smtp.west.cox.net>
Organization: OSDL
X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu)
X-Face: +5V?h'hZQPB9<D&+Y;ig/:L-F$8p'$7h4BBmK}zo}[{h,eqHI1X}]1UhhR{49GL33z6Oo!`
 !Ys@HV,^(Xp,BToM.;N_W%gT|&/I#H@Z:ISaK9NqH%&|AO|9i/nB@vD:Km&=R2_?O<_V^7?St>kW
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2051
Lines: 50

On Mon, 15 Mar 2004 14:08:07 -0700 Tom Rini wrote:

| On Mon, Mar 15, 2004 at 12:54:17PM -0800, Randy.Dunlap wrote:
| > On Mon, 15 Mar 2004 13:43:46 -0700 Tom Rini wrote:
| > | On Mon, Mar 15, 2004 at 12:39:53PM -0800, David S. Miller wrote:
| > | 
| > | > On Mon, 15 Mar 2004 12:00:26 -0700
| > | > Tom Rini <trini@kernel.crashing.org> wrote:
| > | > 
| > | > > That leaves the more general problem of <asm/unistd.h> uses 'asmlinkage'
| > | > > on platforms where either (or both) of the following can be true:
| > | > > - 'asmlinkage' is a meaningless term, and shouldn't be used.
| > | > > - <asm/unistd.h> doesn't include <linux/linkage.h> so it's possible
| > | > >   another file down the line breaks.
| > | > 
| > | > I think the best fix is to include linux/linkage.h in asm/unistd.h as
| > | > you seem to be suggesting, and therefore that is the change I will
| > | > push off to Linus to fix this on sparc32 and sparc64.
| > | 
| > | Erm, if I read include/asm-sparc{,64}/linkage.h right, 'asmlinkage' ends
| > | up being defined to ''.  So why not just remove 'asmlinkage' from the
| > | offending line in unistd.h ?
| > 
| > For future-proofing:  so that it will be like all other $arch/unistd.h,
| 
| It's not nearly all other $arch/unistd.h, it's arm, arm26, i386, ia64,
| ppc64, v850 and x86_64.  Of which, only i386, ia64 and x86_64 arm* do
| anything in <asm/linkage.h>.
| 
| So if we really do want to go down the future-proof <asm-*/unistd.h>
| from the ia-centric folks (<grin>) road, we'd be better off with a patch
| to fix everyone else's $arch/unistd.h.

OK.  :)

| > so that when someone changes the meaning of it, it will just work...?
| 
| The meaning of asmlinkage ?

Sure, it could mean something in the future, for any arch.

Your simple fix sounds good for 2.6.x.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/