Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190221033851.70331-1-yuehaibing@huawei.com>
In-Reply-To: <20190221033851.70331-1-yuehaibing@huawei.com>
From:   Ben Skeggs <skeggsb@gmail.com>
Date:   Fri, 22 Feb 2019 08:11:02 +1000
Message-ID: <CACAvsv7C2pbruAOGM_8f3yyzxhvCgQoKARRRkTzJenEwYc0zTg@mail.gmail.com>
Subject: Re: [Nouveau] [PATCH -next] drm/nouveau/dmem: remove set but not used
 variable 'drm'
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, nouveau@lists.freedesktop.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 21 Feb 2019 at 13:41, YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/nouveau/nouveau_dmem.c: In function 'nouveau_dmem_free':
> drivers/gpu/drm/nouveau/nouveau_dmem.c:103:22: warning:
>  variable 'drm' set but not used [-Wunused-but-set-variable]
>   struct nouveau_drm *drm;
>                       ^
Thanks!  Merged.

>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> index aa9fec80492d..900a302b7ce9 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> @@ -100,12 +100,10 @@ static void
>  nouveau_dmem_free(struct hmm_devmem *devmem, struct page *page)
>  {
>         struct nouveau_dmem_chunk *chunk;
> -       struct nouveau_drm *drm;
>         unsigned long idx;
>
>         chunk = (void *)hmm_devmem_page_get_drvdata(page);
>         idx = page_to_pfn(page) - chunk->pfn_first;
> -       drm = chunk->drm;
>
>         /*
>          * FIXME:
>
>
>
>
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau