Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c238a08cfaae0bd09e434edc889b0ecab50aee24.camel@perches.com>
Subject: Re: [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie
 switches
From:   Joe Perches <joe@perches.com>
To:     Alex_Gagniuc@Dellteam.com, lukas@wunner.de, mr.nuke.me@gmail.com
Cc:     bhelgaas@google.com, Austin.Bolen@dell.com, keith.busch@intel.com,
        Shyam.Iyer@dell.com, okaya@kernel.org, linux-pci@vger.kernel.org,
        mika.westerberg@linux.intel.com, okaya@codeaurora.org,
        poza@codeaurora.org, linux-kernel@vger.kernel.org
Date:   Thu, 21 Feb 2019 17:20:19 -0800
In-Reply-To: <027101b4652c4e0c98b86649aa3e4732@ausx13mps321.AMER.DELL.COM>
References: <20190220012031.10741-1-mr.nuke.me@gmail.com>
         <20190220012031.10741-5-mr.nuke.me@gmail.com>
         <20190221075634.uih5ysqwkna7cku4@wunner.de>
         <027101b4652c4e0c98b86649aa3e4732@ausx13mps321.AMER.DELL.COM>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-02-21 at 18:35 +0000, Alex_Gagniuc@Dellteam.com wrote:
> On 2/21/19 1:57 AM, Lukas Wunner wrote:
> > On Tue, Feb 19, 2019 at 07:20:30PM -0600, Alexandru Gagniuc wrote:
> > > --- a/drivers/pci/hotplug/pciehp_hpc.c
> > > 
> > > +}
> > > +
> > > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_PLX, 0x9733,
> > 
> > By convention there's no blank line between the closing curly brace
> > and the DECLARE_PCI_FIXUP_CLASS_FINAL().

Not completely true.
See: arch/mips/pci/fixup-loongson3.c

> I'm sorry for all the style issues. I realize it's noise and should just 
> be done right from the beginning. Is there a way to make checkpatch.pl 
> catch these before they go out?

You could write a new rule, but it's non trivial as
there are multiple consecutive uses and multi-line
uses too.

I think it's a rule not worth writing.