Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared
 symbols in erofs
To:     <yuzibode@126.com>
References: <20190221142845.13604-1-tsu.yubo@gmail.com>
 <05254fc6-6bd7-7c30-cfcc-2ddff4ac13b6@huawei.com>
 <20190222005753.eibd4zj62askcuad@yubo-2>
CC:     <yuchao0@huawei.com>, <gregkh@linuxfoundation.org>,
        <linux-erofs@lists.ozlabs.org>, <devel@driverdev.osuosl.org>,
        <linux-kernel@vger.kernel.org>, Miao Xie <miaoxie@huawei.com>,
        "fangwei (I)" <fangwei1@huawei.com>
From:   Gao Xiang <gaoxiang25@huawei.com>
Message-ID: <b1f9747b-3276-8139-2997-24836c37bdb8@huawei.com>
Date:   Fri, 22 Feb 2019 09:28:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20190222005753.eibd4zj62askcuad@yubo-2>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/2/22 8:57, YU Bo wrote:
> Hi,
> On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote:
>> Hi Bo,
>>
>> On 2019/2/21 22:28, Bo YU wrote:
>>> From: Bo Yu <tsu.yubo@gmail.com>
>>>
>>> Fix sparse warnings:
>>>
>>> drivers/staging/erofs/utils.c:134:6: warning: symbol
>>> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>>>
>>> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
>>> Cc: Gao Xiang <gaoxiang25@huawei.com>
>>> Cc: Chao Yu <yuchao0@huawei.com>
>>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
>>> ---
>>>  drivers/staging/erofs/utils.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
>>> index b535898ca753..33cd5ad55cb8 100644
>>> --- a/drivers/staging/erofs/utils.c
>>> +++ b/drivers/staging/erofs/utils.c
>>> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>>>      __erofs_workgroup_free(grp);
>>>  }
>>>
>>> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>>                      struct erofs_workgroup *grp,
>>>                      bool cleanup)
>>>  {
>>>
>>
>> Have you looked the latest kernel code?
> Emm...yeah.But i pulled linus tree not staging tree :(
> Sorry for the noise.

That is ok. staging tree or linux-next includes the latest source code,
you can check them out :)

Thanks,
Gao Xiang

> 
>> It seems erofs_try_to_release_workgroup is already be claimed as static...
>>
>> See:
>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
>>
>> Thanks,
>> Gao Xiang
>>