Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp1077571imp; Thu, 21 Feb 2019 18:11:55 -0800 (PST) X-Google-Smtp-Source: AHgI3IYuo/IsRnxfiplzuNUYQ1nCu9yy6DzWKikxddt9tzVQfkNkEzMKpxsJVsO52iysFmRhRiZp X-Received: by 2002:a63:e101:: with SMTP id z1mr1627662pgh.190.1550801515066; Thu, 21 Feb 2019 18:11:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550801515; cv=none; d=google.com; s=arc-20160816; b=LSFQ8O27Vw3yla7Amy/XYP0+cvEfVoO4hjXShFWjUqjcgCOBXdMG9V4pXviYGVnJGg Z2TnuslMm86MUrEUZ7FMXHZjzcDGiC3MUaETHI4usrbkmJtBnchy2aMc/Xp5sIxOVPIP 1YaBAFmUV0zBUTcqa6ulGPkLg+xoMNvJmd4snxo3VKtvnzVBm6G1H3SEyVQ/S+hE7MLM N5k14MZ3FV05m5wRTxwIDjbefvsF/moxPoUG8vhORUur8gnqcgPW2enDbdEPLEUf3Qqh f2MAlsMtaGw+9Qi1yOXuzOA+eHbZ0c5KFkgTV/8qpUdaEmnSWJQTpZLA8BR61Xzuw9NE mDxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=zgwTAb8MJtbzD0GX7M+kWWfrPQA5FApSx+RqYIgOKas=; b=j0LwN5ZA9XgD6140VHjalE69i5X9mNnu5Kav3WEWRw8C+2/PlUiko/ErjJ6D7mU4uk MKoUxGjzDhGiMl3Nc5r4MzD317x9E9Y/dZ0G4fURFxh6pf4HK9iNzZkZCvU00rw8NKxL hIJPV+iWwqP1dW8bL6eTHecddnQ1hVKGEo/td5VQCz6TG3+x+ij+D6B/NlVfAad04c49 VyJiewp4Qvc7b5F9Q3c6r5XWWQ9rMX/BkZF85cpNJgJnAWZ7U2BrVUTNJH+3tQ6rpGqH tYyhNVBzDdkuwDxah+plzvr/2H/VXtc/bxLcBa5R6h5uxirIQBBo6o9UEcqD4Bo1Km/c fZ/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a129si49003pfa.273.2019.02.21.18.11.39; Thu, 21 Feb 2019 18:11:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726886AbfBVCLL (ORCPT + 99 others); Thu, 21 Feb 2019 21:11:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56438 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbfBVCLL (ORCPT ); Thu, 21 Feb 2019 21:11:11 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB8F53097074; Fri, 22 Feb 2019 02:11:10 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-136.pek2.redhat.com [10.72.12.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DBB25C22B; Fri, 22 Feb 2019 02:11:04 +0000 (UTC) Date: Fri, 22 Feb 2019 10:11:01 +0800 From: Dave Young To: Borislav Petkov Cc: bhe@redhat.com, Jerry Hoemann , x86@kernel.org, Randy Dunlap , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Pingfan Liu , Mike Rapoport , Andrew Morton , yinghai@kernel.org, vgoyal@redhat.com, iommu@lists.linux-foundation.org, konrad.wilk@oracle.com, Joerg Roedel Subject: Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr Message-ID: <20190222021101.GA11654@dhcp-128-65.nay.redhat.com> References: <20190131234740.GO6749@zn.tnic> <20190204223016.GB11986@anatevka> <20190205081552.GG21801@zn.tnic> <20190206120804.GC10062@dhcp-128-65.nay.redhat.com> <20190211204816.GB21473@dhcp-128-65.nay.redhat.com> <20190215102458.GD10433@zn.tnic> <20190218014820.GA10711@dhcp-128-65.nay.redhat.com> <20190220083241.GA3447@zn.tnic> <20190220094146.GA8597@dhcp-128-65.nay.redhat.com> <20190221171321.GD12997@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190221171321.GD12997@zn.tnic> User-Agent: Mutt/1.9.5 (2018-04-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 22 Feb 2019 02:11:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/19 at 06:13pm, Borislav Petkov wrote: > On Wed, Feb 20, 2019 at 05:41:46PM +0800, Dave Young wrote: > > Previously Joerg posted below patch, maybe he has some idea. Joerg? > > Isn't it clear from the commit message? Then, does it answered your question? 256M is set as a default value in the patch, but it is not a predict to satisfy all use cases, from the description it is also possible that some people run out of the 256M and the ,low and ,high format is still necessary to exist even if we make crashkernel=X do the allocation automatically in high in case failed in low area. crashkernel=X: allocate in low first, if not possible, then allocate in high In case people have a lot of devices need more swiotlb, then he manually set the ,high with ,low together. What's your suggestion then? remove ,low and ,high and increase default 256M in case we get failure bug report?