Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Feb 2019 21:11:11 -0700
From:   Jerry Hoemann <jerry.hoemann@hpe.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Matt Hsiao <matt.hsiao@hpe.com>, linux-kernel@vger.kernel.org,
        arnd@arndb.de, david.altobelli@hpe.com, mark.rusk@hpe.com
Subject: Re: [PATCH 4/4] misc: hpilo: Update driver version
Message-ID: <20190222041111.GB31132@anatevka>
Reply-To: Jerry.Hoemann@hpe.com
References: <1550736282-25416-1-git-send-email-matt.hsiao@hpe.com>
 <1550736282-25416-5-git-send-email-matt.hsiao@hpe.com>
 <20190221083256.GA6397@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190221083256.GA6397@kroah.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 21, 2019 at 09:32:56AM +0100, Greg KH wrote:
...
> >  
> > -MODULE_VERSION("1.5.0");
> > +MODULE_VERSION("1.5.1");
> 
> This line means nothing, it should just be removed entirely.  The
> "version" of the driver is the kernel version itself.

Hi Greg,

This doesn't hold when we do driver updates.

Our primary means of supporting Linux to our customers is via our
distro partners.  While we prefer to use in distro drivers, HPE does
from time to time deliver driver updates via the "Service Pack for
Proliants" -- The SPP. 

An SPP driver update can supply an updated module without modifying
the underlying base kernel version.  Because of this, the underlying
kernel version number doesn't always imply the version of a module
being used.

Even when we use only in kernel drivers, we also have the case where
our distro partners will back port newer driver versions to an older
distro release.  This gives the situation where an older kernel
version can have a newer module than a newer kernel version for
that distro.

We have found that having module version bumped when modifying the
driver helps us identify the version module actually being used.

Take care,

Jerry

> 
> Want me to drop it?

No. please keep it.  :)

-- 

-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------