Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp1197362imp; Thu, 21 Feb 2019 21:38:28 -0800 (PST) X-Google-Smtp-Source: AHgI3IZpYxqJmX9BiQwxXJPFGJvIcOahXI/9oXd5LIBDmDT3F7ixhZabfXHXyfmh4Rqrjawg6O0C X-Received: by 2002:a62:445a:: with SMTP id r87mr2411989pfa.13.1550813908886; Thu, 21 Feb 2019 21:38:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550813908; cv=none; d=google.com; s=arc-20160816; b=L23kYJkTqSV1L0F9XlIcEJ+uaAmpC2ghTv+lKpWeWxBphxRZboLhnrQgn1aVNuivQ2 3Dvi6UhtuBtIIo0I8Pkz2KV1LrsEN4C+oa1O9Vh2iHgmt+9rwVlKKC2lGPPREq7lf0LE x+/y+sFTDmIY0xLe0sHZ20mjbn7ZdH3KKxY1T/fppP1hgd1d09SSrI9LinEBK6R2cIhb IvIbEbJFH5qIHMtwC38BXRseXtuApEmF3e9rTnJzIRp8dWllb6VSXueHrpXga0dyAxkf wXCbkdC7591xUjV1W93RPmrLg4Irb8aju0VEpv25mU/aC3Rvk49/Bok6BG5qsQ3xPWgn 7ENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=s6I4g4SrIaIM7QBnsUwP/cfK3Sh01UO/ft0HfHQX5CA=; b=aLWoOT95eIH9affNMJElwZ6uQXc2FUuRBSTn9dY4u/G3/iPN8XaV5gllzFqRIGoRqy goQEREgr6kmTHFGlfU/FurJ8ZFhw9XoXyJzud1McDSRKtGXz9txw7Q08OtgmQL7SXquN qt8e2UVtAOKP0b3Sc5mH165aefBYNiHqz3+XPI6olJfmvuU7l2Gxr6R3nfXxW11nf+8c R5wx0oE7ePfUE/9eLDktvt4RpJwrjxMt5BXsEqlNJYC5t0d/PJNr61kHJpOQHQGGioe9 lqAURweweq483VtoeYRIiwegdcQd6rRQDyWT176hdv2Wb+i2jW6xz05SiYvMmIvjSxp9 JcMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z186si517623pgd.477.2019.02.21.21.38.12; Thu, 21 Feb 2019 21:38:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725990AbfBVFhv (ORCPT + 99 others); Fri, 22 Feb 2019 00:37:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725792AbfBVFhs (ORCPT ); Fri, 22 Feb 2019 00:37:48 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 845233097076; Fri, 22 Feb 2019 05:37:48 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-228.ams2.redhat.com [10.36.116.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16A5F600C2; Fri, 22 Feb 2019 05:37:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 160E211AAB; Fri, 22 Feb 2019 06:37:47 +0100 (CET) Date: Fri, 22 Feb 2019 06:37:47 +0100 From: "kraxel@redhat.com" To: Alistair Francis Cc: Alistair Francis , "virtualization@lists.linux-foundation.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "david.abdurachmanov@gmail.com" , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH] drm/bochs: Fix the ID mismatch error Message-ID: <20190222053747.rhed6j6nyi6tmg4l@sirius.home.kraxel.org> References: <20190221003231.31625-1-alistair.francis@wdc.com> <20190221115227.ipwjpn3xm4q7jfg2@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 22 Feb 2019 05:37:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 21, 2019 at 10:44:06AM -0800, Alistair Francis wrote: > On Thu, Feb 21, 2019 at 3:52 AM kraxel@redhat.com wrote: > > > > On Thu, Feb 21, 2019 at 12:33:03AM +0000, Alistair Francis wrote: > > > When running RISC-V QEMU with the Bochs device attached via PCIe the > > > probe of the Bochs device fails with: > > > [drm:bochs_hw_init] *ERROR* ID mismatch > > > > > > This was introduced by this commit: > > > 7780eb9ce8 bochs: convert to drm_dev_register > > > > > > To fix the error we ensure that pci_enable_device() is called before > > > bochs_load(). > > > > > > Signed-off-by: Alistair Francis > > > Reported-by: David Abdurachmanov > > > > Pushed to drm-misc-fixes. > > Thanks. Any chance this will make it into 5.0? Hmm, we are damn close to the release, not sure there will be one more drm-fixes pull req. But I've added a proper Fixes: tag, so even if the patch misses the boat it should land in the stable branches shortly thereafter. cheers, Gerd