Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp1257361imp; Thu, 21 Feb 2019 23:16:31 -0800 (PST) X-Google-Smtp-Source: AHgI3IYghOyKqb0SoOVBKkLbsN2QpvMThfREvcvY436lrGqoK7lFhR3R+4CKBHIhIPL++Q4APmxP X-Received: by 2002:a63:be4d:: with SMTP id g13mr2637483pgo.378.1550819791056; Thu, 21 Feb 2019 23:16:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550819791; cv=none; d=google.com; s=arc-20160816; b=J/7FZ2LJHNG51d7KZECVMwq50jJHYzCYcr6QQJsCOJ63b9PhamsG6+LwNS2bTbLwTR gtfYDrzYFKYVcrDKjmDTcxg3cBW7X5UCex2IcmovJhSP4rRe6MHLYcn+BeDp91pHbG1M QurMAdxf9HFwa9CRIIz6uyz+TkF5BgJURscQkwYBBhU0PsqyzZeZFe75/AxaFh9EMCmD 8GNpJD1G4OLvHuvMB4uoM1kaPqjRiS/qtFfdpBFVLM2QwdjVl44RIsKNvLsiOxE9/E3J vTvTX2Tlul8/rTZ8SkwhgYgTrDVmpUymnn8WZ2iPA6P3ZUfc/+H/YxSbH1d2XGO3AFvi qmCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=Py9iUagj0XjN00Q43/Qz9lvsdbf9NhbHQZJwwPxIcuk=; b=NFR/uMLFtgIR5J81jC6FIE9EO0stIrRLOGnRhRw5rnn1jrbLs2zd56F+sjxpej8/tF /xOIvCDia0TvfGKqkkR3yaCVt1oQsZGFrSnA1OYvjNoa/JZEMmghUCNZqpObXySnRNNM UCZ8eNcmdi1uVPLl4IeDcGceSzG+pOG5PGD8n2ajaNyu0FCcKAJCAfkYgQ+1IpEo7iS8 tCphdKG09XQLhkwUNSfZljsBE9GjQ89j/qffxkjBOfmOkv4Ak2HopuCWemjteSExRqJS A+7s4BzJIv+hrP0bt4RkqmWv6c4QWE47ORKHmen8gyo1s3iwJAwdB/GuujkTI6zMtoTA NzHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e65si762191pfa.80.2019.02.21.23.16.15; Thu, 21 Feb 2019 23:16:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfBVHPv (ORCPT + 99 others); Fri, 22 Feb 2019 02:15:51 -0500 Received: from out1.zte.com.cn ([202.103.147.172]:34964 "EHLO mxct.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726413AbfBVHPt (ORCPT ); Fri, 22 Feb 2019 02:15:49 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 53DAB817848C31868EFA; Fri, 22 Feb 2019 15:15:47 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x1M7FWwV037449; Fri, 22 Feb 2019 15:15:32 +0800 (GMT-8) (envelope-from wen.yang99@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019022215161040-1228945 ; Fri, 22 Feb 2019 15:16:10 +0800 From: Wen Yang To: linus.walleij@linaro.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, nbd@nbd.name, lorenzo.bianconi83@gmail.com, kvalo@codeaurora.org, matthias.bgg@gmail.com, linux-wireless@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, anirudh@xilinx.com, John.Linn@xilinx.com, michal.simek@xilinx.com, wang.yi59@zte.com.cn, Wen Yang Subject: [PATCH 4/5] net: xilinx: fix a leaked reference by adding missing of_node_put Date: Fri, 22 Feb 2019 15:15:41 +0800 Message-Id: <1550819742-32155-4-git-send-email-wen.yang99@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1550819742-32155-1-git-send-email-wen.yang99@zte.com.cn> References: <1550819742-32155-1-git-send-email-wen.yang99@zte.com.cn> X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-02-22 15:16:10, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-02-22 15:15:16, Serialize complete at 2019-02-22 15:15:16 X-MAIL: mse01.zte.com.cn x1M7FWwV037449 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warning: ./drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1624:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1569, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Anirudha Sarangi Cc: John Linn Cc: "David S. Miller" Cc: Michal Simek Cc: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 0789d8a..8335390 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1575,11 +1575,13 @@ static int axienet_probe(struct platform_device *pdev) ret = of_address_to_resource(np, 0, &dmares); if (ret) { dev_err(&pdev->dev, "unable to get DMA resource\n"); + of_node_put(np); goto free_netdev; } lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares); if (IS_ERR(lp->dma_regs)) { dev_err(&pdev->dev, "could not map DMA regs\n"); + of_node_put(np); ret = PTR_ERR(lp->dma_regs); goto free_netdev; } -- 2.9.5