Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190222090921.2068-1-axel.lin@ingics.com>
In-Reply-To: <20190222090921.2068-1-axel.lin@ingics.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Fri, 22 Feb 2019 10:16:34 +0100
Message-ID: <CAMpxmJXTX7RcBqXziFuvmUvZWyWfBaRYmoEORm48mhbF-HN5ZQ@mail.gmail.com>
Subject: Re: [PATCH] regulator: max77650: Fix set_current_limit implementation
To:     Axel Lin <axel.lin@ingics.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

pt., 22 lut 2019 o 10:09 Axel Lin <axel.lin@ingics.com> napisa=C5=82(a):
>
> Current code always return error, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/max77650-regulator.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/max77650-regulator.c b/drivers/regulator/m=
ax77650-regulator.c
> index 411912d5278b..a1af414db751 100644
> --- a/drivers/regulator/max77650-regulator.c
> +++ b/drivers/regulator/max77650-regulator.c
> @@ -243,7 +243,7 @@ static int max77650_regulator_set_current_limit(struc=
t regulator_dev *rdev,
>  {
>         struct max77650_regulator_desc *rdesc;
>         struct regmap *map;
> -       int rv, i, limit;
> +       int i, limit;
>
>         rdesc =3D rdev_get_drvdata(rdev);
>         map =3D rdev_get_regmap(rdev);
> @@ -252,11 +252,9 @@ static int max77650_regulator_set_current_limit(stru=
ct regulator_dev *rdev,
>                 limit =3D max77650_current_limit_table[i];
>
>                 if (limit >=3D min_uA && limit <=3D max_uA) {
> -                       rv =3D regmap_update_bits(map, rdesc->regA,
> +                       return regmap_update_bits(map, rdesc->regA,
>                                         MAX77650_REGULATOR_CURR_LIM_MASK,
>                                         MAX77650_REGULATOR_CURR_LIM_SHIFT=
(i));
> -                       if (rv)
> -                               return rv;
>                 }
>         }
>
> --
> 2.17.1
>

Thanks for spotting that!

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>