Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Feb 2019 23:59:15 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Juerg Haefliger <juerg.haefliger@canonical.com>,
        Shuah Khan <shuah@kernel.org>
Cc:     linux-kernel@vger.kernel.org, rostedt@goodmis.org,
        mingo@redhat.com, Juerg Haefliger <juergh@canonical.com>
Subject: Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033
Message-Id: <20190222235915.bdf82008eef24f8189bd33ec@kernel.org>
In-Reply-To: <20190222091021.10178-3-juergh@canonical.com>
References: <20190220161333.28109-1-juergh@canonical.com>
        <20190222091021.10178-1-juergh@canonical.com>
        <20190222091021.10178-3-juergh@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 22 Feb 2019 10:10:21 +0100
Juerg Haefliger <juerg.haefliger@canonical.com> wrote:

> The \e sequence character is not POSIX. Fix that by using \033 instead.
> 
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>

This also looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> ---
>  tools/testing/selftests/ftrace/ftracetest | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 20c9c0ad8682..136387422b00 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -161,10 +161,10 @@ color_green=
>  color_blue=
>  # If stdout exists and number of colors is eight or more, use them
>  if [ -t 1 -a "$ncolors" -ge 8 ]; then
> -  color_reset="\e[0m"
> -  color_red="\e[31m"
> -  color_green="\e[32m"
> -  color_blue="\e[34m"
> +  color_reset="\033[0m"
> +  color_red="\033[31m"
> +  color_green="\033[32m"
> +  color_blue="\033[34m"
>  fi
>  
>  strip_esc() {
> -- 
> 2.19.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>