Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp1709859imc; Fri, 22 Feb 2019 09:44:27 -0800 (PST) X-Google-Smtp-Source: AHgI3IYoanpjLBMgHQLseX3228uUYt2GGRd0Z5Ylcn3X66Pwt384VuWyTHPB777EpeaNZpLBu0az X-Received: by 2002:a63:d84b:: with SMTP id k11mr5131039pgj.142.1550857467369; Fri, 22 Feb 2019 09:44:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550857467; cv=none; d=google.com; s=arc-20160816; b=0JdMpikZFifeIkruLytFGK4UbEkaMQg1ysRkx1GtIGa9QlQ6tetv6edHeVyM4Q4WuZ 3onuJSqUwg0VPNOmILia4jLl6x/7+rXUkkZNPXn/3oi1DlqH9FqTMwkGRmbqLcSLNLW3 dYUgoOnZGR50jGJ6UPdHRU9jLIdm/jdUjQZmPykTxTbJHiFul2RxiWXDbm3Y9Esrx2qy nt1tdEhlJXRBIrZLuHmeDgcGbavX3Vfq/41PxscVQ6cerHzjNLe/jGGgB2qxxInSA7Ss JT2hFvQIlhXWNisUqcxKMU4swgrIHxX5jOwa4LEhhSBQEfGV9425ctEaWMEZO7oEdrIp DPZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=yKRXvErt07o5tp+Ch7j9nKCwXPl5/sL18WaRQ7Sr6og=; b=RUn1x+X2atzCGDPy/0//ObcLvcFG2S0Y2DXzv6B7E2FVn4F2XUIKVh4h/8OgqtWlEr deRSzrtnQzx4wuTBK5iXjXwnM0QZZ9RyX4aO5xqs71zBRFk2KyWJ8OfZmpUVsvuuslW0 v5b9I4ZehLzxO9K6pVQqUXvhvX9apHn/G7TORHljV/yyKFy9ON0cnv9cHag7XsbKIqSq twRQFLX+z49YoP6sbvA13QTSLpIEEzDwZVUIeZznUAwmHc9HCl+EqwKG6shdg1VkV9GF kvaEqzKQWt+FZ8poAMKL4R9XWB01u3kXp1ch+VuGk5+Kmeq0Pd6F29iG3WX60NlQLl4J iDrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p66si1945040pfp.144.2019.02.22.09.44.12; Fri, 22 Feb 2019 09:44:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfBVRn3 (ORCPT + 99 others); Fri, 22 Feb 2019 12:43:29 -0500 Received: from relay.sw.ru ([185.231.240.75]:59692 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726382AbfBVRn2 (ORCPT ); Fri, 22 Feb 2019 12:43:28 -0500 Received: from [172.16.25.12] (helo=i7.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gxEr3-00010r-5K; Fri, 22 Feb 2019 20:43:21 +0300 From: Andrey Ryabinin To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Ryabinin , Johannes Weiner , Michal Hocko , Vlastimil Babka , Rik van Riel , Mel Gorman Subject: [PATCH 1/5] mm/workingset: remove unused @mapping argument in workingset_eviction() Date: Fri, 22 Feb 2019 20:43:33 +0300 Message-Id: <20190222174337.26390-1-aryabinin@virtuozzo.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org workingset_eviction() doesn't use and never did use the @mapping argument. Remove it. Signed-off-by: Andrey Ryabinin Cc: Johannes Weiner Cc: Michal Hocko Cc: Vlastimil Babka Cc: Rik van Riel Cc: Mel Gorman --- include/linux/swap.h | 2 +- mm/vmscan.c | 2 +- mm/workingset.c | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 649529be91f2..fc50e21b3b88 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -307,7 +307,7 @@ struct vma_swap_readahead { }; /* linux/mm/workingset.c */ -void *workingset_eviction(struct address_space *mapping, struct page *page); +void *workingset_eviction(struct page *page); void workingset_refault(struct page *page, void *shadow); void workingset_activation(struct page *page); diff --git a/mm/vmscan.c b/mm/vmscan.c index ac4806f0f332..a9852ed7b97f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -952,7 +952,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page, */ if (reclaimed && page_is_file_cache(page) && !mapping_exiting(mapping) && !dax_mapping(mapping)) - shadow = workingset_eviction(mapping, page); + shadow = workingset_eviction(page); __delete_from_page_cache(page, shadow); xa_unlock_irqrestore(&mapping->i_pages, flags); diff --git a/mm/workingset.c b/mm/workingset.c index dcb994f2acc2..0906137760c5 100644 --- a/mm/workingset.c +++ b/mm/workingset.c @@ -215,13 +215,12 @@ static void unpack_shadow(void *shadow, int *memcgidp, pg_data_t **pgdat, /** * workingset_eviction - note the eviction of a page from memory - * @mapping: address space the page was backing * @page: the page being evicted * * Returns a shadow entry to be stored in @mapping->i_pages in place * of the evicted @page so that a later refault can be detected. */ -void *workingset_eviction(struct address_space *mapping, struct page *page) +void *workingset_eviction(struct page *page) { struct pglist_data *pgdat = page_pgdat(page); struct mem_cgroup *memcg = page_memcg(page); -- 2.19.2