Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp1722630imc; Fri, 22 Feb 2019 09:59:04 -0800 (PST) X-Google-Smtp-Source: AHgI3IY+y09I5ZSIRHb0DFGHGOhN74fxgoF4JJr9rGnVqo0WPErxIjV8caLaLTsuQt0RZDVBldc0 X-Received: by 2002:a17:902:5a42:: with SMTP id f2mr5379683plm.157.1550858344673; Fri, 22 Feb 2019 09:59:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550858344; cv=none; d=google.com; s=arc-20160816; b=atJk/y0FNRBwLWHDSx2z7h06MTXIxd3KHafwjNgPWWIVR50+GqvBArKYE29pfD7uun GmNvDPZ58zQgRs+PbVfqAysYtJdO7NBedLxMcjhAnU2LuETp9fel/9U5QWhKtAyVgi4+ Simqm9s/wKbpLcJCR370f2KYdnW0XaNRMZSspVoF6oHtKf/dpChFshiimqYyVOjpnaOg pjHvS+zt/SPKdX8bBpbJklhiS15rs6svY6BEWhTvDBHekF8fLXLGqKt9BRDLAc8WcNr6 bsNmKn6iNoHKt2UnVNMEgd5CJGje7pfLT88UagaJO/Vhe+1cvjY4swJBMNC/R701xRs1 1ORg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=3KBE2Qh+C69wQpCAeSupmWywi6LIzCfXVSgE2xb2V9w=; b=b15JmBAAQj1OYMg0EcIGwDyf7JtE5ZM7+giSsm7nOhE4Pr97nvKOtVN39ebpL/Mdzv 4HY8c3b9gUXwpkHgYtzqw8W3R8KC0YSy8dOJOwCKS8GWToRR9PBzoQnHgr2Z4fSXcipx fjmJ5FEAgKbMqV8+31llHxnCBIJnZrhzsxowjaa3h2AGkyUFxEh2PuNyD529x4yI27hm To2pCS5jRe+eskjA2vibUA7WYiWw6xiTpHzh3wGpDN8OHatA0Er3lVTQdRvNCLhqdiFK GIIwoEhMYhis+MMw7+TeF7O7yBmUtem1Y/hgGv1+6D5uQ2fNTNd7/2wjJyq21nwq94nE k/WQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k125si1890228pfc.21.2019.02.22.09.58.49; Fri, 22 Feb 2019 09:59:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727325AbfBVR6G (ORCPT + 99 others); Fri, 22 Feb 2019 12:58:06 -0500 Received: from namei.org ([65.99.196.166]:53646 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfBVR6F (ORCPT ); Fri, 22 Feb 2019 12:58:05 -0500 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id x1MHviVm014713; Fri, 22 Feb 2019 17:57:44 GMT Date: Sat, 23 Feb 2019 04:57:44 +1100 (AEDT) From: James Morris To: "Gustavo A. R. Silva" cc: John Johansen , "Serge E. Hallyn" , Mimi Zohar , Dmitry Kasatkin , Casey Schaufler , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v2] security: mark expected switch fall-throughs and add a missing break In-Reply-To: <20190208205453.GA3232@embeddedor> Message-ID: References: <20190208205453.GA3232@embeddedor> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Feb 2019, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=] > security/integrity/ima/ima_policy.c:940:18: warning: this statement may fall through [-Wimplicit-fallthrough=] > security/integrity/ima/ima_policy.c:943:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > security/integrity/ima/ima_policy.c:972:21: warning: this statement may fall through [-Wimplicit-fallthrough=] > security/integrity/ima/ima_policy.c:974:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > security/smack/smack_lsm.c:3391:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > security/apparmor/domain.c:569:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris