Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Cc:     <bhelgaas@google.com>, <Austin.Bolen@dell.com>,
        <keith.busch@intel.com>, <Shyam.Iyer@dell.com>, <okaya@kernel.org>,
        <linux-pci@vger.kernel.org>, <gustavo@embeddedor.com>,
        <linux-kernel@vger.kernel.org>
From:   <Alex_Gagniuc@Dellteam.com>
To:     <lukas@wunner.de>, <mr.nuke.me@gmail.com>
Subject: Re: [PATCH RFC v2 2/4] PCI: pciehp: Do not turn off slot if presence
 comes up after link
Thread-Topic: [PATCH RFC v2 2/4] PCI: pciehp: Do not turn off slot if presence
 comes up after link
Thread-Index: AQHUyLqR+ed3yG3ljUu42ub7Hwypsg==
Date:   Fri, 22 Feb 2019 19:56:28 +0000
Message-ID: <dfeadc6798984cce965e2202e90fe0b0@ausx13mps321.AMER.DELL.COM>
References: <20190220012031.10741-1-mr.nuke.me@gmail.com>
 <20190220012031.10741-3-mr.nuke.me@gmail.com>
 <20190221073634.snvazxlzgvjhilaz@wunner.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/21/19 1:36 AM, Lukas Wunner wrote:=0A=
> On Tue, Feb 19, 2019 at 07:20:28PM -0600, Alexandru Gagniuc wrote:=0A=
>>   	mutex_lock(&ctrl->state_lock);=0A=
>> +	present =3D pciehp_card_present(ctrl);=0A=
>> +	link_active =3D pciehp_check_link_active(ctrl);=0A=
>>   	switch (ctrl->state) {=0A=
> =0A=
> These two assignments appear to be superfluous as you're also performing=
=0A=
> them in pciehp_check_link_active().=0A=
=0A=
Not sure. Between the first check, and this check, you can have several =0A=
seconds elapse depending on whether the driver's .probe()/remove() is =0A=
invoked. Whatever you got at the beginning would be stale. If you had a =0A=
picture dictionary and looked up 'bad idea', it would have a picture of =0A=
the above code with the second check removed.=0A=
=0A=
I've got all the other review comments addressed in my local branch. I'm =
=0A=
waiting on Lord Helgass' decision on which solution is better.=0A=
=0A=
Alex=0A=
=0A=
=0A=