Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp1849469imc; Fri, 22 Feb 2019 12:21:42 -0800 (PST) X-Google-Smtp-Source: AHgI3IZziqzUMvf+UTTMpQTKp+lb5AEoXX0antTrybhALA3wdyO5z4RwDvfI7xZoDgalL5P7GUMA X-Received: by 2002:a62:5e41:: with SMTP id s62mr5919905pfb.232.1550866902479; Fri, 22 Feb 2019 12:21:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550866902; cv=none; d=google.com; s=arc-20160816; b=gE9MqkL7zyVJ8Qz0OntO7EBIklR5e0RhO5UTQIo1pT7fI4esKnO8UD0zw62h7UKqEn 2a7ah5dbvfSYpBXXQWIS8AEpAr5pdGIFZzA8/HaUQVC/keiSWxro4Es2LQ0tmb4Ss5TD IutSl5d0t0t9dSONlRhuJZZHiasxd15u5msyIz+4hegsBDlhUj0+E7/4z9FTXodEOw/y KzDDIbWJoyzk42YfeYr0wwN26yW2F/CKiEpuOpANZi6wMe8IHHE1u27cDfwDXOshlMz8 rs2z6r3RMuVYciMw+wAFWqMWlblCALVOjRQbDUOrBPp8ZcCfhHFBSVblqcKgqcJ0xy82 LgXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nPu7TUAGJUbzY11xcVwQR8OVx4CJd93Pgak9brPfP0o=; b=AiwWQ2AI3ehj20zoD98w0pezFlITNel4T9gky+1xLZoI3aTW2Zh6QqIcwLgAgH2YfP IovSMAk1u0AEDZ4PuctjiHobTnAmPw/5n/eLvMafC7HG7WRzCc5i8x5kdUUobX4QtlB1 Q7XK7Gpg5xTl/ati2RRa0AowKN4PllMPlruDeMW5pj2VzArvOYYUTXLuu9XQa05iVFkj Plcg4Ym4Je+R8wr8irV3sH2xOylOCg/5tNh5A/Ku0mD9a67rUtq2qJSwq/jbUSvMc+7h thcm0xrtMxEFYg9EQTal2n3NTZ56USJedGqI2HsCa8rhQyLRB5pMX3IXNqNx4t91gSLF tLQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JthjGUjv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y35si2162516pgl.569.2019.02.22.12.21.26; Fri, 22 Feb 2019 12:21:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JthjGUjv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726441AbfBVUVA (ORCPT + 99 others); Fri, 22 Feb 2019 15:21:00 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:32904 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbfBVUVA (ORCPT ); Fri, 22 Feb 2019 15:21:00 -0500 Received: by mail-lf1-f65.google.com with SMTP id q12so2694493lfm.0 for ; Fri, 22 Feb 2019 12:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nPu7TUAGJUbzY11xcVwQR8OVx4CJd93Pgak9brPfP0o=; b=JthjGUjvJNPIYZpKp19nplYYUyZZ8rgs8+HUfea1M8Xx9ERSTB4aRUlEmX2DBY8HEL OTWHcV4P5DzPfRGDGTz3cryUtjxI4btweIQh81nUWkqq2QLtAp6puF0kLPVrQpOZ9v8H VmhjgSLuAyds1hfdVNOlHOMz0j+W4vC/lWc433aoColAhQtGWeYoE4wN2ChOvM7we8LG FU1YcEBYd7wNV12jiXtbDZnHCKcL4TId1lb1g0xC4La/2xXiuT4AN4dnni0KqBOyl3Y0 eXAoHwgexPyrUcnppSsgANX1nJ56+BG8UDW+158UgdhhgB0GytV7aZY418l92ZWWLJJG LuUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nPu7TUAGJUbzY11xcVwQR8OVx4CJd93Pgak9brPfP0o=; b=JpizKZDfYICHqDP4OICVqbKOLiAAfpKviz+ysAXceKFvMpWWHuAb+4vavYG3kdH6Me iHVNvY2B8pKxVcT125sYlrTOoUDJ/Y1GEiRHN8Ajur64WnFXzxDisA5CBKOE/7KJM+6b vShFqREmF9sXfw4cR9QR5j+bpPVIrEI1RjIqxmZRyVUy6Hp+1Dv/8WbdIYT/uk4o8Qce 6239mhQMQiU2G5SLbprM7D9X5n5iS1xSgs9T3iDYywqE5iutlUyZl7YltTKVGPFtUppI piDpiAn47z1bTqan3G8RoyI0nm1WIpvgRHbmO2dU+Xtu5hF+Y0lO883Uyetsynun9ZcX VQug== X-Gm-Message-State: AHQUAub9226UwuFdQZjTCZaL6xmmIYDNw+CoLIed9RVaDgNOY0zsLZV+ zv1yqSpexzn/mShTKYKC3n8= X-Received: by 2002:a19:9a8d:: with SMTP id c135mr3423650lfe.100.1550866858061; Fri, 22 Feb 2019 12:20:58 -0800 (PST) Received: from metis.ciupak.eu ([31.130.108.122]) by smtp.gmail.com with ESMTPSA id m18sm726431lfh.43.2019.02.22.12.20.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Feb 2019 12:20:57 -0800 (PST) Date: Fri, 22 Feb 2019 21:20:56 +0100 From: Marcin Ciupak To: Greg Kroah-Hartman Cc: Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v4] staging: nrf24: add new driver for 2.4GHz radio transceiver Message-ID: <20190222202055.udjbsm5qkxzkqcdh@metis.ciupak.eu> References: <20190213194035.n2ldlt7xque5qaps@metis.ciupak.eu> <20190219102010.GA18634@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219102010.GA18634@kroah.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 19, 2019 at 11:20:10AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 13, 2019 at 08:40:35PM +0100, Marcin Ciupak wrote: > > This patch adds driver for Nordic Semiconductor nRF24L01+ radio > > transceiver. > > > > Signed-off-by: Marcin Ciupak > > --- > > Changes in v2: > > - add terminating newlines to all logging formats > > Changes in v3: > > - patch subject > > - comments cleanup > > - goto labels cleanup > > - scnprintf bugfix > > - ida_simple_remove bugfix > > Changes in v4: > > - fix smatch warnings > > What is preventing this from being merged today with the normal > subsystem for this type of drivers? Why does this have to go into > staging? > > thanks, > > greg k-h As per TODO file: +Todo: +- opening and closing pipes via sysfs +- improve switching in between RX and TX +- improve handling of MAX_RT interrupt +- find and fix bugs +- code cleanup Additionally, I would like to add ioctl (or any similar) interface as configuration via sysfs is not very efficent in here. My beliefes are that this driver needs some time in staging, but I might be wrong and if you believe otherwise just let me know and I will try to push it ti regular sybsystem. Thanks, Marcin