Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp1978552imc; Fri, 22 Feb 2019 15:08:23 -0800 (PST) X-Google-Smtp-Source: AHgI3IZH80PVvp8Pm6WIYkgNlV16MfyvCgU11eGgdX3iMkdE0Lgu5rembKc7QK5RdZT7+LohRE3i X-Received: by 2002:a17:902:4d46:: with SMTP id o6mr6364359plh.302.1550876903133; Fri, 22 Feb 2019 15:08:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550876903; cv=none; d=google.com; s=arc-20160816; b=H7SEn7YCXcnzDUSN5PgZNADxc5Mu4iJ3Db3CpLOtFaKXvIFAKJ4yvFiRqeFc4qhw5s B+0C+rx/yaNURyjSr+reIcx/UvR+kcjsguuk+AByVg4N/pPo7F2N3kxdIerPEFhKMy6Y VfJwE/HN7aKIp8rKy/hLuYT1D3U8L5unHFqOF0cMy9fV01k5vv3JzMNwgqRwK0fvjOTV slvQU2yO+FSC4Q9wTs7XRNf2ZmkZB1bGlso9xHn2iA71SPbnwFDFfvlUdxoIJAAEMon7 WdISeaZj1QhPjR97gotauYSvyOH57hYzYRTR3Yo4fyPAgHH4jIa2Gcpp+YHgANozuluZ i30Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+3ai/hsVcDWYDMmMGVG6D7Ixn/biqggmfKSVNhtu2NA=; b=QZs7lQKFHLGjloQp3tncl0u9CKgGO17lzbqo3wu2WOnN9tT7SsX7DFMnChTC5qye60 w2krolGUmc3aRpNI2ZxJleUQF7MrimiP/yCptYETYU0bIiLsE+KizjOOq0ECUPR0JtGB HFu/d4CEkk/5zn3aWybEVihXvZL4jnd4ul2Vzq5pklrs7KkzpWNMlqDgwvzkNsHhAe5d 4iEsAfpU4sVT4JyO91DmymnYkj/XYQK+7DJ8ZHzjyLwvg62+ProOuz1gFhNrS+/zPGpa MkTAVaHxAV3MeTO3OOsp3m2TwLKrnMuAzGzStSWpL+QW7OZU6viLcxkS6Rlv/ycdfJoE /j+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c19si2444439plo.410.2019.02.22.15.08.08; Fri, 22 Feb 2019 15:08:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727659AbfBVXHF (ORCPT + 99 others); Fri, 22 Feb 2019 18:07:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:52570 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726595AbfBVXHD (ORCPT ); Fri, 22 Feb 2019 18:07:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EE155B60F; Fri, 22 Feb 2019 23:07:01 +0000 (UTC) From: Tony Jones To: linux-kernel@vger.kernel.org Cc: linux-perf-users@vger.kernel.org, acme@kernel.org, Tony Jones , Seeteena Thoufeek , Paolo Bonzini Subject: [PATCH 11/15] perf script python: add Python3 support to stackcollapse.py Date: Fri, 22 Feb 2019 15:06:15 -0800 Message-Id: <20190222230619.17887-12-tonyj@suse.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190222230619.17887-1-tonyj@suse.de> References: <20190222230619.17887-1-tonyj@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Support both Python2 and Python3 in the stackcollapse.py script There may be differences in the ordering of output lines due to differences in dictionary ordering etc. However the format within lines should be unchanged. The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Paolo Bonzini --- tools/perf/scripts/python/stackcollapse.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/perf/scripts/python/stackcollapse.py b/tools/perf/scripts/python/stackcollapse.py index 1697b5e18c96..5e703efaddcc 100755 --- a/tools/perf/scripts/python/stackcollapse.py +++ b/tools/perf/scripts/python/stackcollapse.py @@ -19,6 +19,8 @@ # Written by Paolo Bonzini # Based on Brendan Gregg's stackcollapse-perf.pl script. +from __future__ import print_function + import os import sys from collections import defaultdict @@ -120,7 +122,6 @@ def process_event(param_dict): lines[stack_string] = lines[stack_string] + 1 def trace_end(): - list = lines.keys() - list.sort() + list = sorted(lines) for stack in list: - print "%s %d" % (stack, lines[stack]) + print("%s %d" % (stack, lines[stack])) -- 2.20.1