Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Niklas =?iso-8859-1?Q?S=F6derlund?=" <niklas.soderlund@ragnatech.se>
Date:   Sat, 23 Feb 2019 02:44:22 +0100
To:     Shuah Khan <shuah@kernel.org>
Cc:     mchehab@kernel.org, hans.verkuil@cisco.com, keescook@chromium.org,
        sakari.ailus@linux.intel.com, colin.king@canonical.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] au0828: minor fix to a misleading comment in _close()
Message-ID: <20190223014422.GS11484@bigcity.dyn.berto.se>
References: <20190222174559.8084-1-shuah@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190222174559.8084-1-shuah@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Shuah,

Thanks for your patch.

On 2019-02-22 10:45:59 -0700, Shuah Khan wrote:
> Fix misleading comment in _close()
> 
> Signed-off-by: Shuah Khan <shuah@kernel.org>
> ---
>  drivers/media/usb/au0828/au0828-video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
> index 7876c897cc1d..08f566006a1f 100644
> --- a/drivers/media/usb/au0828/au0828-video.c
> +++ b/drivers/media/usb/au0828/au0828-video.c
> @@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
>  		 * so the s_power callback are silently ignored.
>  		 * So, the current logic here does the following:
>  		 * Disable (put tuner to sleep) when
> -		 * - ALSA and DVB aren't not streaming;
> +		 * - ALSA and DVB aren't streaming;

Nit-picking, as you are modifying the line anyhow I would s/;/./
With or without this changed,

Reviewed-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>

>  		 * - the last V4L2 file handler is closed.
>  		 *
>  		 * FIXME:
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas S?derlund