Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190223063939.18261-1-tsu.yubo@gmail.com>
In-Reply-To: <20190223063939.18261-1-tsu.yubo@gmail.com>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Sat, 23 Feb 2019 07:46:56 +0100
Message-ID: <CAMhs-H9L7fB7eC_TJ1HR3G=vyjc6eEanwN82qH0ExCV1C1b1dw@mail.gmail.com>
Subject: Re: [PATCH] staging/ks7070: Removed unused varibale
To:     Bo YU <tsu.yubo@gmail.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>, quytelda@tamalin.org,
        devel@driverdev.osuosl.org,
        linux-kernel <linux-kernel@vger.kernel.org>, yuzibode@126.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Bo,

On Sat, Feb 23, 2019 at 7:39 AM Bo YU <tsu.yubo@gmail.com> wrote:
>
> From: Bo Yu <tsu.yubo@gmail.com>
>
> Compiling the kernel with W=3D1 results in the following warning:
>
> drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable =E2=80=98mib_=
val_type=E2=80=99
> set but not used [-Wunused-but-set-variable]
>   u16 mib_val_type;
>
> drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable =E2=80=98mib_=
val_size=E2=80=99
> set but not used [-Wunused-but-set-variable]
>     u16 mib_val_size;
>
> drivers/staging/ks7010/ks_hostif.c:786:6: warning: variable =E2=80=98resu=
lt_code=E2=80=99
> set but not used [-Wunused-but-set-variable]
>       u16 result_code;
>
> Remove these variables.
>
> Rebase on next-20190222
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> Cc: Quytelda Kahja <quytelda@tamalin.org>
>
> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/=
ks_hostif.c
> index d938b0997a53..913d8996437a 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -461,13 +461,9 @@ void hostif_mib_get_confirm(struct ks_wlan_private *=
priv)
>         struct net_device *dev =3D priv->net_dev;
>         u32 mib_status;
>         u32 mib_attribute;
> -       u16 mib_val_size;
> -       u16 mib_val_type;
>
>         mib_status =3D get_dword(priv);
>         mib_attribute =3D get_dword(priv);
> -       mib_val_size =3D get_word(priv);
> -       mib_val_type =3D get_word(priv);
>
>         if (mib_status) {
>                 netdev_err(priv->net_dev, "attribute=3D%08X, status=3D%08=
X\n",
> @@ -783,9 +779,7 @@ void hostif_ps_adhoc_set_confirm(struct ks_wlan_priva=
te *priv)
>  static
>  void hostif_infrastructure_set_confirm(struct ks_wlan_private *priv)
>  {
> -       u16 result_code;
>
> -       result_code =3D get_word(priv);
>         priv->infra_status =3D 1; /* infrastructure mode set */
>         hostif_sme_enqueue(priv, SME_MODE_SET_CONFIRM);
>  }
> --
> 2.11.0
>

PATCH commit message is wrong: format, typos and driver name:

[PATCH] staging/ks7070: Removed unused varibale

Should be "staging: ks7010: removed unused variables"

Thanks,
    Sergio Paracuellos