Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp2277776imc; Fri, 22 Feb 2019 23:19:42 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia3Htd/M7hin1WDsdmQRSUGfv9R/OSSe8He86GV+LqEeLJqglHiSNBsWaiaegHNrq9Bk5Ee X-Received: by 2002:a63:ce4a:: with SMTP id r10mr7409577pgi.336.1550906382183; Fri, 22 Feb 2019 23:19:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550906382; cv=none; d=google.com; s=arc-20160816; b=Bbgz4tvbaanqke2vX6S88s19FwZ8cf/uuExy+VkqEfYH+595hzfTSwlKTstImbpuQ3 KBMQZGfvZX2dvcLWouJ908zjD3WUH7iBgA6M9eF7ZuNz+UpCLQTTNceJ6NnWJVX9qiEI urVn1XycWBTn5P4Q0hS1bT8wXSV9HD6fnoHE4A156mVaTKScqb/leEb9MYuxix84/+MI uVTSfvajVxecwkY3/xbHLH0x+1hlKJjANWwAX9w3mdSA+MIUjwTGBq2d02heh2ijl8kT C8KbgaGTbp3CPF5YnvitQMKehH4IkvWeaQoGsi3qbmPzwQ5O0cW5JIa4UBFiRf5F3wjy 6MUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bKaiT4Jm4bntz660DNaINIYyQfhJHMYyUQadrCK9ejY=; b=zwls/an4CsMXRmlih5UHxfqQyUz34JkzwyHzX1foaBXluBbYR6jh0Z6+z9GvD9S0CC zFy/S4HXGBFSwV1Z67Tde/mvHnNrw0IJhzzgl1fR19Qm5hwFZD1ulWISDdEBx4AWBzn5 rBxuotYwEe2yp3kFSTPnD+KCkC5RFAcu5Ej6zTa91ef7Zpz/zvrDyHBroUjCO58JyGXv f6or30adBONqWE1lCCSK6wVUvR2gMiI1V/nmrxHifEvbVucgAPFxuRqS4mT6KJsMEs4e AMrAbxnL1MUDzLaWvUU4IKvglqLpstxVs1DNww5tNX3fH9f0YOg4TZ1TDgf+4IscqHJ5 W6VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=0+Qr59sD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si3230716pgm.426.2019.02.22.23.19.14; Fri, 22 Feb 2019 23:19:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=0+Qr59sD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727060AbfBWHSb (ORCPT + 99 others); Sat, 23 Feb 2019 02:18:31 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:36576 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725898AbfBWHSb (ORCPT ); Sat, 23 Feb 2019 02:18:31 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1N7Es0O170230; Sat, 23 Feb 2019 07:18:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2018-07-02; bh=bKaiT4Jm4bntz660DNaINIYyQfhJHMYyUQadrCK9ejY=; b=0+Qr59sD0mVv6vvRWm3WXBpNy6QuzpeWyM9lLK3t53bZhT9uQo+qmabnLlpYuCy92j08 2RwBTTlGwowNufQqJoBAoHfUvAdiaY/6xMcq3vLe5zjHFBUughKAo+U3Iua6GLxEaxCD XvwrNCXovhNa542IL5c4IQfRl2alsixzbqVY1jsGg0Pne8xmeTxDzwxW7UyeDUTjQh9K UB/jefmwhvJThnEIewpa5o0gSUyY+V3c0a6eC9BnvteRHkcpZzA30tz0s0Gk8j/aa5tb 3CzQh35101LjQ1rH8xqkBdCUW1nrkBLDGa25+AEHcpCS/b2NTtwbO7iq8RPKL7WfavgU 1w== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2qtwktrab7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 23 Feb 2019 07:18:22 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1N7ILw9023894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 23 Feb 2019 07:18:21 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1N7ILuo026681; Sat, 23 Feb 2019 07:18:21 GMT Received: from kadam (/41.202.241.61) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Feb 2019 23:18:20 -0800 Date: Sat, 23 Feb 2019 10:18:12 +0300 From: Dan Carpenter To: Bo YU Cc: gregkh@linuxfoundation.org, sergio.paracuellos@gmail.com, quytelda@tamalin.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, yuzibode@126.com Subject: Re: [PATCH] staging/ks7070: Removed unused varibale Message-ID: <20190223071812.GE1737@kadam> References: <20190223063939.18261-1-tsu.yubo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190223063939.18261-1-tsu.yubo@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9175 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=774 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902230052 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 23, 2019 at 01:39:39AM -0500, Bo YU wrote: > From: Bo Yu > > Compiling the kernel with W=1 results in the following warning: > > drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ > set but not used [-Wunused-but-set-variable] > u16 mib_val_type; > > drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’ > set but not used [-Wunused-but-set-variable] > u16 mib_val_size; > > drivers/staging/ks7010/ks_hostif.c:786:6: warning: variable ‘result_code’ > set but not used [-Wunused-but-set-variable] > u16 result_code; > > Remove these variables. > > Rebase on next-20190222 ^^^^^^^^^^^^^^^^^^^^^^^ Is this a v2 patch or something? Don't include this in the changelog. Put it under the --- cut off line. > > Cc: Greg Kroah-Hartman > Cc: Sergio Paracuellos > Cc: Quytelda Kahja > > Signed-off-by: Bo Yu > --- ^^^ > drivers/staging/ks7010/ks_hostif.c | 6 ------ > 1 file changed, 6 deletions(-) > regards, dan carpenter