Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Juerg Haefliger <juerg.haefliger@canonical.com>
Date:   Sat, 23 Feb 2019 13:25:51 +0100
To:     shuah <shuah@kernel.org>
Cc:     Juerg Haefliger <juerg.haefliger@canonical.com>,
        linux-kernel@vger.kernel.org, rostedt@goodmis.org,
        mingo@redhat.com, mhiramat@kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033
Message-ID: <20190223132551.5afc02bb@smeagol>
In-Reply-To: <aedb3a7e-058e-ec62-93c7-0767717b9ea9@kernel.org>
References: <20190222091021.10178-1-juergh@canonical.com>
        <20190222205351.743-1-juergh@canonical.com>
        <20190222205351.743-3-juergh@canonical.com>
        <aedb3a7e-058e-ec62-93c7-0767717b9ea9@kernel.org>
Organization: Canonical Ltd
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/sR5IvWWqWP4IEeSfd.dqVN+"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/sR5IvWWqWP4IEeSfd.dqVN+
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Fri, 22 Feb 2019 15:46:03 -0700
shuah <shuah@kernel.org> wrote:

> On 2/22/19 1:53 PM, Juerg Haefliger wrote:
> > The \e sequence character is not POSIX. Fix that by using \033 instead.
> >=20
> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> > Signed-off-by: Juerg Haefliger <juergh@canonical.com>
> > ---
> >   tools/testing/selftests/ftrace/ftracetest | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >=20
> > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/=
selftests/ftrace/ftracetest
> > index 20c9c0ad8682..136387422b00 100755
> > --- a/tools/testing/selftests/ftrace/ftracetest
> > +++ b/tools/testing/selftests/ftrace/ftracetest
> > @@ -161,10 +161,10 @@ color_green=3D
> >   color_blue=3D
> >   # If stdout exists and number of colors is eight or more, use them
> >   if [ -t 1 -a "$ncolors" -ge 8 ]; then
> > -  color_reset=3D"\e[0m"
> > -  color_red=3D"\e[31m"
> > -  color_green=3D"\e[32m"
> > -  color_blue=3D"\e[34m"
> > +  color_reset=3D"\033[0m"
> > +  color_red=3D"\033[31m"
> > +  color_green=3D"\033[32m"
> > +  color_blue=3D"\033[34m"
> >   fi
> >  =20
> >   strip_esc() {
> >  =20
>=20
> Which release is this patch based on?
>=20
> This one failed to apply to linux-kselftest next - I resolved a minor
> merge conflict and applied it. Please review to make sure it looks good.

Looks good. It didn't apply cleanly because you don't have
https://lore.kernel.org/lkml/20190220153706.24686-1-juergh@canonical.com/T/=
#u
Sorry about not copying you on that patch. Want me to resend?

...Juerg


> thanks,
> -- Shuah


--Sig_/sR5IvWWqWP4IEeSfd.dqVN+
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEhZfU96IuprviLdeLD9OLCQumQrcFAlxxO9AACgkQD9OLCQum
QrcFhRAAjcfgCqTkG5+qxPmKD2RJbcCmi2ml1jPxnHjWbY1yU9mnR6bp+n0PQr7M
GV3RSk+8UcBIEHZf7wXz/Iaj89rkR77Hsf5DlxPghxxrsvXtb0sJblvLbwAvEoeE
m0147o9YJ7oXl9abw3MI9vJEol2bOPuv5CFOMIILKH6XCTqzo5zE9DbyGG/MhPXh
VTuD9KQ4cRsX2puHRvX5jtilLyjzoyLRCk0UpUJ+1UVN2i8CIq9z3p76z1+byQCm
pal2aCVcrIcbLUMQ7XKnLXniuYljCm5yNs256Q17gfLtK9yytMkKdKaor/G4u+vD
zdja8zz/ixTrGkqD+QGq9FYH3SbDfk04wLUGCqFu4TFSZHECrFOy5GAxMLbg5fsX
izDm/6E55n7ij1XyDf9x66584Q9tecmFWKMKM5abG68TodkKIWONYo2BlZbJcfRE
w0Y6xozmoWPtppKVXBHiMJmi0ARDhkQqSxJZIqZqnZ8YFWN8Txs1lnSIgHeFZCAM
XoqOk0XfxBfjnI/rJWPc+2fKgvKe7BUxjOv8u9OQd+M3LXVpRjKOhTwvEyvatIcy
nNFgyreSCvu9ni346qX56igSY1mXEQlevkn3hZIBRIBlZ7C+J9wSlPZY7ObCNA2Q
9MhPT6wQHtLg2b+YfUFfd7jd0dY/bFFTDbIMkLmJP5RTEDREDCM=
=qHuo
-----END PGP SIGNATURE-----

--Sig_/sR5IvWWqWP4IEeSfd.dqVN+--