Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp3180495imc; Sat, 23 Feb 2019 22:30:14 -0800 (PST) X-Google-Smtp-Source: AHgI3IYnz6wMV0OcBysE5l96d8MGw6cUuwLZGT6wJBDZeuG5UVAdw9whyJ+d2ZiVBVSPGlMS31SW X-Received: by 2002:a63:1322:: with SMTP id i34mr11683128pgl.208.1550989814912; Sat, 23 Feb 2019 22:30:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550989814; cv=none; d=google.com; s=arc-20160816; b=adUmv9E8FD9+LKkXGfsipjFToD1LcUgTHGVZuAg72v2UxwI/ctnxt3cyc7PTBf/P8V 4yQ+pwgEfpUV+e+KL0eRisdCNHS9bZKgNoXvqbPcArW0ed0ZKtSnK96nIEWRpAuF3mMQ b/K+SxyM8nHkOU5xE2WIISiyK/DsDCWSA8lsDTkIlZ2Vush6sCbHcVq+lD3q0lqf9z3i 28CfWh9D5hN23G5i45q4jR+bUg1qsxuFLOnYPqA66lgdqcKp+dXDBm0M2q3JcgAJA7DF ml18MW60SxrGXQAMaIe/x1yTmN5Z2O3efagOFla91Mbi+2z7y5mdjv31kkW22LLhpRFz 4/0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=O5KmjtDOazqxu/d6uEfa/p4LWQFRoPd5xkqVrZgJqfU=; b=eZowzm39mWqdjv4KHBC4BZ9n6NVvjn38jq4n9vnqn2B2eqjOwp+3d8h+uResPwXSx/ rsDt9/L+a8EvSQlabXo+FWqGK6pDmcl31HLNyLMG6Z3eMbr2lHObqQA8srq5xnN3J9X/ FVz/cqZALerjjPISdT+xKGPqK10cwKneszJcOUn7Q9I84VlAaQUuf6EBYBWYIJJSHSdL axVNahRUMkIr4rq37224hxtB5JyjwVXjBjdcd5aSI02y9duaccFmU7J/2IYlj1qKOuSC 6ut8YGZ4IE+Z/rlFXoIeiZote+Ro9mxTpnvaeKLO/fvo1Lr/Eflilk0M72Utbin6ULms MxEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f67si5254875pgc.182.2019.02.23.22.29.59; Sat, 23 Feb 2019 22:30:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbfBXG1S (ORCPT + 99 others); Sun, 24 Feb 2019 01:27:18 -0500 Received: from 61-228-51-238.dynamic-ip.hinet.net ([61.228.51.238]:35352 "EHLO E6440.gar.corp.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725817AbfBXG1S (ORCPT ); Sun, 24 Feb 2019 01:27:18 -0500 X-Greylist: delayed 561 seconds by postgrey-1.27 at vger.kernel.org; Sun, 24 Feb 2019 01:27:18 EST Received: from E6440.gar.corp.intel.com (localhost [127.0.0.1]) by E6440.gar.corp.intel.com (Postfix) with ESMTP id 8A76BC1602; Sun, 24 Feb 2019 14:18:16 +0800 (CST) From: Harry Pan To: LKML Cc: harry.pan@intel.com, gs0622@gmail.com, rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org Subject: [PATCH v6 2/2] PM / sleep: measure the time of filesystems syncing Date: Sun, 24 Feb 2019 14:17:54 +0800 Message-Id: <20190224061753.17638-2-harry.pan@intel.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20190224061753.17638-1-harry.pan@intel.com> References: <20190222154904.6260-1-harry.pan@intel.com> <20190224061753.17638-1-harry.pan@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch gives the reader an intuitive metric of the time cost by the kernel issuing filesystems sync during system sleep; although developer can guess by the timestamp of next log or enable the ftrace power event for manual calculation, this manner is easier to read and benefits the automation script. Signed-off-by: Harry Pan --- kernel/power/main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/kernel/power/main.c b/kernel/power/main.c index a8a8e6ec57e6..a08dcc743f31 100644 --- a/kernel/power/main.c +++ b/kernel/power/main.c @@ -54,9 +54,15 @@ EXPORT_SYMBOL_GPL(unlock_system_sleep); void ksys_sync_helper(void) { - pr_info("Syncing filesystems ... "); + ktime_t start; + s64 elapsed_msecs; + + start = ktime_get(); ksys_sync(); - pr_cont("done.\n"); + elapsed_msecs = ktime_to_ms(ktime_sub(ktime_get(), start)); + pr_info("Filesystems sync: %lld.%03lld seconds\n", + elapsed_msecs / MSEC_PER_SEC, + elapsed_msecs % MSEC_PER_SEC); } EXPORT_SYMBOL_GPL(ksys_sync_helper); -- 2.18.1