Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp3558624imc; Sun, 24 Feb 2019 07:38:04 -0800 (PST) X-Google-Smtp-Source: AHgI3IaYYnVfIqlPRYeWSnOCHCzjtWGWD31tYHE53+wJQ1Pwsmc5TQY4ZWQJGaZ0BNf736685bab X-Received: by 2002:a65:51ca:: with SMTP id i10mr13622505pgq.371.1551022684282; Sun, 24 Feb 2019 07:38:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551022684; cv=none; d=google.com; s=arc-20160816; b=i6vnDfjHO0ETTfUWXKjW0MMPK0DK5fdZyOv9N3Z6xyDkRiAZpTo96kkXps8loZz2zd ZV3mq7i3wGnHTh3BXh8e/Yxe+coOxjghWZ2OAdgJVaO1W1q3DF9K91h/ogPaBhRExzDV YH+T2mL3H0ZNBFiPC22IS+9XsjH0GnOGues4W2k+2xTWWAD3qwR18/6TUFBi+TO5eF2t DVxl1sO80qwflFhDyJMfbuYkG8cdpCcqw6Grcc0jtCYp5pD5ougbqU/OpZ/r+WBOZQEq moJScF1O8tEIN778TFQ3yi11fnk4LS5wH4BO+utUTw0Y41Up+DkCsENddvXmBIN1WU1C yEMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OC7kn1GcMpo3s3dcHCTtzeyKC4a2ZnIHHhN4xw+WDZc=; b=TS8yK2StyFrFQht2aA3SheOZMbawC0Hgfaynu1LC7uJMPF0C11jPYTJgRi//BhDQS8 FO9sqJh9wR9FhzbCy+JExGFWWSs8mI5nEGGI+ZUat8f5ulOP/Su7yJqNUnekLOhKYFO1 m06Oe0BbJ9qSovprr+6UCg/W3EAkjtRGoZ2WDoRuCQojP3Wd7QvcEFrqWnX6NR5YgcnH QIdHvkHcB6MDSd4GFK7m5ijiqXyiSFZN/0FgR1rFnSfGFDVIuPkPbrgZNPAqkAB2YHeZ NRlNaGb+lcU63xSBv7d+VO9ss5sHUnlcn/Upl3t5CVKy5nGT616Qi4kt6VlJe+if5q/+ 4x5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="mP/lgAIP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g127si6476390pgc.313.2019.02.24.07.37.49; Sun, 24 Feb 2019 07:38:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="mP/lgAIP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728417AbfBXPhT (ORCPT + 99 others); Sun, 24 Feb 2019 10:37:19 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:42063 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726458AbfBXPhS (ORCPT ); Sun, 24 Feb 2019 10:37:18 -0500 Received: by mail-pl1-f194.google.com with SMTP id s1so3284323plp.9; Sun, 24 Feb 2019 07:37:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OC7kn1GcMpo3s3dcHCTtzeyKC4a2ZnIHHhN4xw+WDZc=; b=mP/lgAIPrpq+WUjaR+QfNzLzKVcrCKEd4VYrOFsSH01scsp/yFv3VuKqx+QHrL5QCc E+MmQOFrH/mJeDQlJ7slQBiXZZ5zQ7UbwPuL7KKOdxHZH4/tyFe5RPcTVJedXLCwrLQx AA+AqnLyyVEuir8fJC6rcy1p/kI7u8DzN6p9dDDxJ3HMLjfbZsmHoMYz7/yIZhmCaYCO 2kyuTCocGn+CCtmrXBP+dyDlLuuQ6LbD5zyOLUqskaoPOYO6pA0ushxAe0XmTW8Ps3FL OVIwELCMAgd9XfFMKsPR8ks0enhKyfYZHRJYVXnixCg/THuZ3NBvjWQEATQNqUV2jTsn U4Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OC7kn1GcMpo3s3dcHCTtzeyKC4a2ZnIHHhN4xw+WDZc=; b=XAEus+Nk9juJOLwFa3g7w3TUT8zS5yMvpmV1aqbAar157JFcQf7Ql47L9K+nuaBRbG ib+xVw8P3VV/GA+AbWB0Eh85XZOpqYWIMOO+Cddu0Ej6tGJp6UtlUIsIMNKHDpp4aD5U 3OcuBTb7V4KFphvf37LR6IRKaC4udIEhHs9ByjYa5NUKv6Pk0n7qR4GASBV2x9XaA9Ai olEz8tvevP3XWJwDmWg8vyXlViC1woGb8xfzed+jULpSNmZJKwtfd+iWURAzYZnRbhKn Ap4Kv6ULis0Gx+zFhIulw/pMVcnxGMBomegFuK/QJszlfZBUHfzh+3R/GAXrIP9LGgPX UlvA== X-Gm-Message-State: AHQUAua0iSDikYP7jcnHQAk4tdI0xY27LMtXExvgwllOExSwHHwhs546 2YiUPOIrl8AA+urDSveESYA= X-Received: by 2002:a17:902:a03:: with SMTP id 3mr15009276plo.112.1551022638230; Sun, 24 Feb 2019 07:37:18 -0800 (PST) Received: from bharath12345-Inspiron-5559 ([103.110.42.34]) by smtp.gmail.com with ESMTPSA id v26sm10588675pfg.62.2019.02.24.07.37.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Feb 2019 07:37:17 -0800 (PST) Date: Sun, 24 Feb 2019 21:07:12 +0530 From: Bharath Vedartham To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] badblocks: Prefer unsigned int over unsigned Message-ID: <20190224153712.GA11981@bharath12345-Inspiron-5559> References: <20190224141952.GA3653@bharath12345-Inspiron-5559> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 24, 2019 at 08:15:30AM -0700, Jens Axboe wrote: > On 2/24/19 7:19 AM, Bharath Vedartham wrote: > > Replace unsigned with unsigned int to improve readability. > > Frivolous change, would make a lot more sense to get checkpatch > to stop complaining about this. > > -- > Jens Axboe > I understand. I am starting out kernel hacking. I have been working on fixing checkpatch.pl warnings. If you have any tasks for me in the kernel, it would be great. I have also noticed a lot of warnings to replace printk with subsystem specific warning functions. Is that a valuable change? Bharath