Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp3591868imc; Sun, 24 Feb 2019 08:17:58 -0800 (PST) X-Google-Smtp-Source: AHgI3IZRKvk9D4glpLD4SaxouAVDB5G4cC6zN4OHFSNUyyw0XQKLOuxbd8OzwEncR00RGqyjBHx8 X-Received: by 2002:a63:4b0a:: with SMTP id y10mr14139778pga.66.1551025078714; Sun, 24 Feb 2019 08:17:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551025078; cv=none; d=google.com; s=arc-20160816; b=Pv6vbasZxNFv3CMrZCDfV1Pddv+3snexDkMt6pDkHGUaZMQmwA/Hb4oW55BVV1Buo/ KZggdIkaiSqvcU5vhu6i53MW4WZoyePt9s2rLQGmhOzVEetfBpozc25GmuTOzVJDnM55 8bS9OEBqO3IOt7L4G8lbmHQT8qX+pyg4GYn3yYFfZxc1fX/gDyN0Ka1U26dNbAHaCagI E8LVQzW9FGWyPzunjwozNCZUzNDi4boEOORR1b+o+weXBiL1LzxLcz3XioE55aefn/FW gIb48y+JStwh3xli5rJCt6pplVexMTJGRL9SmBpJfnYTR0660B7l4PIBZhXUYVEMwYk0 Zxtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=2faXSzxXqxrhqZwVVI2uwy0/vTPRpZyN9fE1OW1kyQA=; b=ZmdYhgQh5S9F+wQIYTrezq5yH+dO+YLxwYXRAFOlkzwRmiZ6vYRrFk0Ml730oYBWOy n5BE315VObmLXolyhjmVwN5eBE4ZPszGKHR8oCfrRYChEpjJ3UopPjAgx8GJPFkob41J /Ufkq+wDKk5He4cOQEwDIHlsc4mKmREC4cPdgefPuoKIu4RPDER4yMpGdDB7sMJ6C4rr jsPZXmZXmMnLHYrwi5DGRDyvyps4bFgsRiToc9lfstpk74LivJNgIjkiQsI7a9v5d4S/ 9n6aKF0vps5TPlnNWbG+AxH7Bfsmg471YjdDmt93WrOuYrlFjxXZmJXy26ggFiHdATCf SsNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cHF+14wS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w9si6822740pgj.69.2019.02.24.08.17.43; Sun, 24 Feb 2019 08:17:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cHF+14wS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbfBXQRV (ORCPT + 99 others); Sun, 24 Feb 2019 11:17:21 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:42283 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbfBXQRU (ORCPT ); Sun, 24 Feb 2019 11:17:20 -0500 Received: by mail-oi1-f194.google.com with SMTP id s16so5396593oih.9; Sun, 24 Feb 2019 08:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2faXSzxXqxrhqZwVVI2uwy0/vTPRpZyN9fE1OW1kyQA=; b=cHF+14wSWZWajT1m/i9Fja8vO1vjAQEqkrvCwaFoWgsObtLl7HmFflDoAhyjccsKjy wO3qLT2dVeDhV1RuTuBteHO1RLtKrEICrTaPiekGWfeuldg0oYNuJtla/86e0OsNstLs 0DA9w7U02LHI/Z5+rUzjz8PxD1BUE7hDkGYk/VYe3kAb+d9Y0ycueZw6lhw1K7P9GrHt V1HMnLirfUr8UZ2y/60izuAoF2BvEpFQnq4mD17QyNYY+gy67QyIxuIsDPy0IAJVfGO3 Jb8Me/0CxxijbCIcWa4d6W+F6qWQneJbvA13qiAFGtYhgGzlVFsfeWqLbjpJmjRhxn6j L0Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2faXSzxXqxrhqZwVVI2uwy0/vTPRpZyN9fE1OW1kyQA=; b=c7fqy3buArcT2m3UUTdQt2VVNhZMkODD4cgdWY1nEfCtWflVmNDIyy3gILvB2uHvdD J5iMOJ65l4azOTXagvUyDFm8ceYsUji+w+Xa0hyEBd5Dc73TKN2A7FeVP6bUtNrsma8K xAuji1GZZMLPWKQm/wlshF7ShLrVD++pV2SKk5IWXYPc91mDOYjWLQEGVMiWMib21ta5 nEEyC0DJ6gIQy2rxe89uaA90iZBg3HFMiVBZUtfzwY3UichaK6tT3qvImM77nOQ53zRL C2/IQLYU3FKD3bgYNI5N4odKLLNFl227ipALmNBI2zwl2Bx45G3HrIrkVz0tIjTuwzHe IOfg== X-Gm-Message-State: AHQUAuaY5/hIJqT7hsbkjJiAo8OTdgjjTh0wEmkfqS2z7c3UqChVXWHF pm907E4UzE66qorYkdjyULI= X-Received: by 2002:aca:293:: with SMTP id 141mr8832709oic.28.1551025039452; Sun, 24 Feb 2019 08:17:19 -0800 (PST) Received: from [192.168.1.2] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.googlemail.com with ESMTPSA id r11sm3353288oib.45.2019.02.24.08.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Feb 2019 08:17:18 -0800 (PST) Subject: Re: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check To: Ioana Ciornei , "netdev@vger.kernel.org" Cc: Ioana Ciocoi Radulescu , Greg Kroah-Hartman , "open list:DPAA2 ETHERNET SWITCH DRIVER" , "open list:STAGING SUBSYSTEM" References: <20190222220214.25401-1-f.fainelli@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: Date: Sun, 24 Feb 2019 08:17:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 2/23/19 à 12:45 AM, Ioana Ciornei a écrit : > >> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check >> >> port_switchdev_event() does not check that the target network device is >> actually backed by the ethsw driver, this could be problematic in a stacked >> environment case. >> > > Just FYI, I sent a patch set containing a similar patch verifying if the netdev is backed by the ethsw: > https://lkml.org/lkml/2019/2/6/216 > > I sent the entire patch set against the staging tree. Thank you. BTW do you have any plans for moving this driver out of staging? It looks pretty good to me to get promoted in tree, provided that you also have all the dependencies in place etc. -- Florian